Closed Bug 1234563 Opened 8 years ago Closed 8 years ago

In ImageBitmap.h: error: ‘mozilla::gfx::DrawTarget’ has not been declared

Categories

(Core :: DOM: Core & HTML, defect)

43 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1234744

People

(Reporter: ignisvulpis, Assigned: ignisvulpis)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20151210085006

Steps to reproduce:

Added a new webidl to Firefox.
The code is here: https://github.com/AxelNennker/firefox_credentials


Actual results:

Compiler complains in a completely unrelated file ImageBitmap.h

 0:45.01 UnifiedBindings14.o
 0:54.55 In file included from /media/sdb1/mozilla/obj-x86_64-unknown-linux-gnu/dom/bindings/OffscreenCanvasBinding.cpp:9:0,
 0:54.55                  from /media/sdb1/mozilla/obj-x86_64-unknown-linux-gnu/dom/bindings/UnifiedBindings14.cpp:2:
 0:54.55 ../../dist/include/mozilla/dom/ImageBitmap.h:102:29: error: ‘mozilla::gfx::DrawTarget’ has not been declared
 0:54.55    PrepareForDrawTarget(gfx::DrawTarget* aTarget);
 0:54.55                              ^
 0:54.55 
 0:54.55 In the directory  /media/sdb1/mozilla/obj-x86_64-unknown-linux-gnu/dom/bindings
 0:54.56 The following command failed to execute properly:
 0:54.56 /usr/bin/ccache c++ -o UnifiedBindings14.o -c -I/media/sdb1/mozilla/obj-x86_64-unknown-linux-gnu/dist/stl_wrappers -I/media/sdb1/mozilla/obj-x86_64-unknown-linux-gnu/dist/system_wrappers -include /media/sdb1/mozilla/firefox/config/gcc_hidden.h -DOS_POSIX=1 -DOS_LINUX=1 -DHAVE_SIDEBAR -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/media/sdb1/mozilla/firefox/dom/bindings -I. -I../../dist/include/mozilla/dom -I/media/sdb1/mozilla/firefox/dom/base -I/media/sdb1/mozilla/firefox/dom/battery -I/media/sdb1/mozilla/firefox/dom/bluetooth/common/webapi -I/media/sdb1/mozilla/firefox/dom/camera -I/media/sdb1/mozilla/firefox/dom/canvas -I/media/sdb1/mozilla/firefox/dom/geolocation -I/media/sdb1/mozilla/firefox/dom/html -I/media/sdb1/mozilla/firefox/dom/indexedDB -I/media/sdb1/mozilla/firefox/dom/media/webaudio -I/media/sdb1/mozilla/firefox/dom/media/webspeech/recognition -I/media/sdb1/mozilla/firefox/dom/svg -I/media/sdb1/mozilla/firefox/dom/workers -I/media/sdb1/mozilla/firefox/dom/xbl -I/media/sdb1/mozilla/firefox/dom/xml -I/media/sdb1/mozilla/firefox/dom/xslt/base -I/media/sdb1/mozilla/firefox/dom/xslt/xpath -I/media/sdb1/mozilla/firefox/dom/xul -I/media/sdb1/mozilla/firefox/js/xpconnect/src -I/media/sdb1/mozilla/firefox/js/xpconnect/wrappers -I/media/sdb1/mozilla/firefox/layout/style -I/media/sdb1/mozilla/firefox/layout/xul/tree -I/media/sdb1/mozilla/firefox/media/mtransport -I/media/sdb1/mozilla/firefox/media/webrtc -I/media/sdb1/mozilla/firefox/media/webrtc/signaling/src/common/time_profiling -I/media/sdb1/mozilla/firefox/media/webrtc/signaling/src/peerconnection -I../../ipc/ipdl/_ipdlheaders -I/media/sdb1/mozilla/firefox/ipc/chromium/src -I/media/sdb1/mozilla/firefox/ipc/glue -I../../dist/include -I/media/sdb1/mozilla/obj-x86_64-unknown-linux-gnu/dist/include/nspr -I/media/sdb1/mozilla/obj-x86_64-unknown-linux-gnu/dist/include/nss -fPIC -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/UnifiedBindings14.o.pp -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe -DDEBUG -DTRACING -g -freorder-blocks -Os -fno-omit-frame-pointer -Wno-uninitialized /media/sdb1/mozilla/obj-x86_64-unknown-linux-gnu/dom/bindings/UnifiedBindings14.cpp
 0:54.56 make[5]: *** [UnifiedBindings14.o] Error 1
 0:54.56 make[4]: *** [dom/bindings/target] Error 2
 0:54.56 make[3]: *** [compile] Error 2
 0:54.56 make[2]: *** [default] Error 2
 0:54.56 make[1]: *** [realbuild] Error 2
 0:54.56 make: *** [build] Error 2



Expected results:

I think that the declaration of DrawTarget is missing in ImageBitmap.h

Adding it to ImageBitmap.h resolves this error.
 27 namespace gfx {
 28 class DataSourceSurface;
 29 class SourceSurface;
 30 class DrawTarget;
 31 }
Component: Untriaged → DOM
Product: Firefox → Core
Sounds right. Want to upload a patch?
Attached patch DrawTarget.patchSplinter Review
This fixes the error although that does not explain why it works in other cases.
unified builds may lead to this kinds of odd compilation issues - at least that is what I guess is the reason here.
Who could review and approve this?
Comment on attachment 8701138 [details] [diff] [review]
DrawTarget.patch

Review of attachment 8701138 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, this is in DOM code, so I'll sign off on it.
Attachment #8701138 - Flags: review?(bas) → review+
Assignee: nobody → ignisvulpis
Status: UNCONFIRMED → NEW
Ever confirmed: true
failed to apply:

patching file dom/canvas/ImageBitmap.h
Hunk #1 FAILED at 21
1 out of 1 hunks FAILED -- saving rejects to file dom/canvas/ImageBitmap.h.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh DrawTarget.patch
Flags: needinfo?(ignisvulpis)
Keywords: checkin-needed
The fix is already in place.
http://mxr.mozilla.org/mozilla-central/source/dom/canvas/ImageBitmap.h#29 
It was fixed by :TYLin in bug 1234744 .
Flags: needinfo?(ignisvulpis)
does this mean this does need a new patch or is this done ?
Flags: needinfo?(ignisvulpis)
Flags: needinfo?(bzbarsky)
It's done.  Axel, next time you get review, please add the checkin-needed keyword if the reviewer forgets to do it?  I'm sorry this got lost.... :)
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(bzbarsky)
Resolution: --- → DUPLICATE
Flags: needinfo?(ignisvulpis)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: