1234566 - LoadLibrary used instead of LoadLibraryA in gfx/skia/skia/src/ports/SkOSLibrary_win.cpp

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Bob Owen (:bobowen)]

Can't change to defining UNICODE everywhere as file gfx/skia/skia/src/ports/SkOSLibrary_win.cpp uses LoadLibrary when it should be LoadLibraryA


Upstream issue filed: https://bugs.chromium.org/p/skia/issues/detail?id=4735

Comment 1

[Bob Owen (:bobowen)]

Attachment: Use LoadLibraryA instead of LoadLibrary in SkOSLibrary_win.cpp to allow UNICODE to be defined.

Comment 2

[Bob Owen (:bobowen)]

Attachment: Use LoadLibraryA instead of LoadLibrary in some skia Windows code to allow UNICODE to be defined

Patch already landed upstream on skia in commit 7a897c0f796df0a1c5b4ee5930b29bfed17ad1b4.

Comment 3

[Lee Salzman [:lsalzman]]

Comment on attachment 8703733 [details] [diff] [review]
Use LoadLibraryA instead of LoadLibrary in some skia Windows code to allow UNICODE to be defined

We got this upstreamed, so no problems now.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/700d49664df6

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/700d49664df6