Use channel.asyncOpen2 within netwerk/test/unit/test_http2.js

RESOLVED FIXED in Firefox 46

Status

()

Core
DOM: Security
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ckerschb, Assigned: mcmanus)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Updated

2 years ago
Assignee: nobody → mozilla
Blocks: 1193558
Status: NEW → ASSIGNED
(Reporter)

Comment 1

2 years ago
Created attachment 8701104 [details] [diff] [review]
bug_1234591_asyncopen2_test_http2.patch

Hi Pat, this test (without the patch from this bug applied) faces a similar issue than test_spdy.js within Bug 1234366, see:

 0:01.23 LOG: Thread-1 INFO exiting test
 0:01.23 PROCESS_OUTPUT: Thread-1 (pid:395) "JavaScript error: /Users/ckerschb/Documents/moz/mc/testing/xpcshell/head.js, line 208: uncaught exception: 2147500036"
 0:01.23 TEST_STATUS: Thread-1 testOnStopRequest PASS [testOnStopRequest : 75] true == true
 0:01.24 TEST_STATUS: Thread-1 testOnStopRequest FAIL [testOnStopRequest : 80] false == true
/Users/ckerschb/Documents/moz/mc-obj-ff-dbg/_tests/xpcshell/netwerk/test/unit/test_http2.js:testOnStopRequest:80
/Users/ckerschb/Documents/moz/mc/testing/xpcshell/head.js:_do_main:208
/Users/ckerschb/Documents/moz/mc/testing/xpcshell/head.js:_execute_test:535
-e:null:1



That patch attached however should work once that issue is resolved. I don't think we need the second argument in all these cases and it's fine to just remove it. Do you agree or am I missing something?
Attachment #8701104 - Flags: review?(mcmanus)
(Assignee)

Comment 2

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e4181f3cab8
(Assignee)

Updated

2 years ago
Attachment #8701104 - Attachment is obsolete: true
Attachment #8701104 - Flags: review?(mcmanus)
(Assignee)

Comment 3

2 years ago
Created attachment 8701633 [details] [diff] [review]
Use channel.asyncOpen2 within netwerk/test/unit/test_http2.js
Attachment #8701633 - Flags: review?(mozilla)
(Assignee)

Updated

2 years ago
Assignee: mozilla → mcmanus
(Reporter)

Comment 4

2 years ago
Comment on attachment 8701633 [details] [diff] [review]
Use channel.asyncOpen2 within netwerk/test/unit/test_http2.js

Review of attachment 8701633 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks!
Attachment #8701633 - Flags: review?(mozilla) → review+
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/66459e9c625aebece347c8f0aae1e4be57f5f70a
Bug 1234591 - Use channel.asyncOpen2 within netwerk/test/unit/test_http2.js r=ckerschb

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/66459e9c625a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.