1234691 - about:serviceworkers broken due to pushService.getRegistration()

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

It seems something has broken about:serviceworkers.  I'm only seeing a single registration and no buttons.  In browser console I see:

  TypeError: pushService.getRegistration is not a function

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Looks like this is bustage from bug 1189998.  The name should be getSubscription() now, not getRegistration().

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Fix about:serviceworkers to use correct nsIPushService getSubscription() ca ll. r=baku

This fixes about:serviceworkers for me locally.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7541ac4978d5

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8701238 [details] [diff] [review]
Fix about:serviceworkers to use correct nsIPushService getSubscription() ca ll. r=baku

Approval Request Comment
[Feature/regressing bug #]: bug 1189998
[User impact if declined]: about:serviceworkers does not work which is a regression from 44
[Describe test coverage new/current, TreeHerder]: local testing
[Risks and why]: Minimal as this only affects service workers and the bustage is very clear.
[String/UUID change made/needed]: None

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7541ac4978d5

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8701238 [details] [diff] [review]
Fix about:serviceworkers to use correct nsIPushService getSubscription() ca ll. r=baku

regression, taking it.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm hitting conflicts uplifting this to aurora. Can we get a rebased patch?

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

The regressing bug was backed out on 45, so we don't need to uplift this.  Sorry for the confusion.