Closed
Bug 1234691
Opened 8 years ago
Closed 8 years ago
about:serviceworkers broken due to pushService.getRegistration()
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox44 | --- | unaffected |
firefox45 | --- | unaffected |
firefox46 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
(Keywords: regression)
Attachments
(1 file)
It seems something has broken about:serviceworkers. I'm only seeing a single registration and no buttons. In browser console I see: TypeError: pushService.getRegistration is not a function
Assignee | ||
Comment 1•8 years ago
|
||
Looks like this is bustage from bug 1189998. The name should be getSubscription() now, not getRegistration().
Assignee | ||
Updated•8 years ago
|
status-firefox44:
--- → unaffected
status-firefox45:
--- → affected
Assignee | ||
Comment 2•8 years ago
|
||
This fixes about:serviceworkers for me locally.
Attachment #8701238 -
Flags: review?(amarchesini)
Updated•8 years ago
|
Attachment #8701238 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8701238 [details] [diff] [review] Fix about:serviceworkers to use correct nsIPushService getSubscription() ca ll. r=baku Approval Request Comment [Feature/regressing bug #]: bug 1189998 [User impact if declined]: about:serviceworkers does not work which is a regression from 44 [Describe test coverage new/current, TreeHerder]: local testing [Risks and why]: Minimal as this only affects service workers and the bustage is very clear. [String/UUID change made/needed]: None
Attachment #8701238 -
Flags: approval-mozilla-aurora?
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7541ac4978d5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•8 years ago
|
Keywords: regression
Comment 6•8 years ago
|
||
Comment on attachment 8701238 [details] [diff] [review] Fix about:serviceworkers to use correct nsIPushService getSubscription() ca ll. r=baku regression, taking it.
Attachment #8701238 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I'm hitting conflicts uplifting this to aurora. Can we get a rebased patch?
Flags: needinfo?(bkelly)
Assignee | ||
Comment 8•8 years ago
|
||
The regressing bug was backed out on 45, so we don't need to uplift this. Sorry for the confusion.
Flags: needinfo?(bkelly)
Updated•8 years ago
|
Attachment #8701238 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•