Closed Bug 1234730 Opened 4 years ago Closed 4 years ago

Synced tabs "please login" state isn't quite centered.

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 46
Tracking Status
firefox45 --- verified
firefox46 --- verified

People

(Reporter: markh, Assigned: markh)

Details

Attachments

(1 file)

It's not centered by just a few pixels. The problem is that the "open sync prefs" button has a large margin that forces the pane to be too big. The solution is to have no left or right margin on these buttons.
Attachment #8701297 - Flags: review?(adw)
Attachment #8701297 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/36634a31d101
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8701297 [details] [diff] [review]
0001-Bug-XXXXXXX-fix-centering-of-synced-tabs-login-pane..patch

Approval Request Comment
[Feature/regressing bug #]: Synced Tabs panel.
[User impact if declined]: Minor visual issue
[Describe test coverage new/current, TreeHerder]: Existing tests pass.
[Risks and why]: Very low risk simple CSS only change.
[String/UUID change made/needed]: None
Attachment #8701297 - Flags: approval-mozilla-aurora?
Assignee: nobody → markh
Comment on attachment 8701297 [details] [diff] [review]
0001-Bug-XXXXXXX-fix-centering-of-synced-tabs-login-pane..patch

Polishing patch, taking it.
Attachment #8701297 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have reproduced this bug on Nightly 46.0a1 (2015-12-22) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Nightly 46.0a1!

Build ID: 20160105030211
User Agent: Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0
QA Whiteboard: [bugday-20160106]
Thanks!
Status: RESOLVED → VERIFIED
Flags: firefox-backlog+
This Bug is now verified as fixed on Latest Firefox 45.0 Beta 7 

User Agent:Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
QA Whiteboard: [bugday-20160106] → [bugday-20160106][testday-20160219]
You need to log in before you can comment on or make changes to this bug.