1234730 - Synced tabs "please login" state isn't quite centered.

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-XXXXXXX-fix-centering-of-synced-tabs-login-pane..patch

It's not centered by just a few pixels. The problem is that the "open sync prefs" button has a large margin that forces the pane to be too big. The solution is to have no left or right margin on these buttons.

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/36634a31d101

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/36634a31d101

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8701297 [details] [diff] [review]
0001-Bug-XXXXXXX-fix-centering-of-synced-tabs-login-pane..patch

Approval Request Comment
[Feature/regressing bug #]: Synced Tabs panel.
[User impact if declined]: Minor visual issue
[Describe test coverage new/current, TreeHerder]: Existing tests pass.
[Risks and why]: Very low risk simple CSS only change.
[String/UUID change made/needed]: None

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8701297 [details] [diff] [review]
0001-Bug-XXXXXXX-fix-centering-of-synced-tabs-login-pane..patch

Polishing patch, taking it.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f872e1fe7959

Comment 6

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 46.0a1 (2015-12-22) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Nightly 46.0a1!

Build ID: 20160105030211
User Agent: Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Thanks!

Comment 8

[Bolaram Paul [:ancon]]

This Bug is now verified as fixed on Latest Firefox 45.0 Beta 7 

User Agent:Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0