1234732 - [email] HeaderCursor seems to be insantiated multiple times for message_list somehow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

On bug 1234488 I noticed that the front-end seems to be invoking viewFolderMessages() twice for each folder which suggests 2 HeaderCursors are being created when one should be, suggesting maybe in the most recent refactor we ended up with two things happening when there should only be one.

Hopefully with that knowledge this is trivial/obvious, but I'm expecting maybe there may be some decisions needed by :jrburke, so assigning/needinfoing to :jrburke for now.

Note that with the fix for bug 1234488 this becomes an efficiency issue, although it wouldn't surprise me if some other back-end edge cases might be exposed by this.

If a repro is required, I've noticed this with the following scenario:
- Already have some accounts created.
- Add a new ActiveSync account.
- Enter the inbox, note that 2 slices are created.
- Switch to a different folder, note that the 2 slices die and 2 new ones are created.

Enabling the realtime log dumping will expose the viewFolderMessages and killSlice messages if you want some (very chatty) debug to help you identify what's going on.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] jrburke:bug1234732-email-cleanup-header-cursor > mozilla-b2g:master

Comment 2

[James Burke [:jrburke]]

Comment on attachment 8704933 [details] [review]
[gaia] jrburke:bug1234732-email-cleanup-header-cursor > mozilla-b2g:master

Review notes in the pull request. Basically, missed cleaning up a defunct HeaderCursor instance.

Comment 3

[James Burke [:jrburke]]

Merged in Gaia master:
https://github.com/mozilla-b2g/gaia/commit/664e9c376606b9633d20e24edd5b6fa0ab9edadf