Incorrect locale language tag in Honeycomb EOL url

RESOLVED FIXED in Firefox 45

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: liuche, Assigned: Margaret)

Tracking

Trunk
Firefox 46
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox45 fixed, firefox46 fixed, fennec45+)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
We should use Locales.getLanguageTag(Locale.getDefault()) instead of just Locale.getDefault() in the Honeycomb EOL message.
(Assignee)

Comment 1

2 years ago
I see this isn't an issue for the other SUMO URLs we format from Java:
http://hg.mozilla.org/mozilla-central/annotate/35b211eaad1f/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java#l851
http://hg.mozilla.org/mozilla-central/annotate/35b211eaad1f/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#l3373

Maybe we need to move the logic to format these links into some sort of helper method so that we don't make this mistake again.
tracking-fennec: --- → 45+
(Assignee)

Comment 2

2 years ago
Created attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

Review commit: https://reviewboard.mozilla.org/r/28973/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28973/
Attachment #8701484 - Flags: review?(liuche)
(Assignee)

Updated

2 years ago
Assignee: nobody → margaret.leibovic
(Reporter)

Updated

2 years ago
Attachment #8701484 - Flags: review?(liuche) → review+
(Reporter)

Comment 3

2 years ago
Comment on attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

https://reviewboard.mozilla.org/r/28973/#review25735
(Reporter)

Comment 4

2 years ago
https://reviewboard.mozilla.org/r/28973/#review25737
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/14aea198d5b18b4850801a23c61cbd066bf93f4f
Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche
(Assignee)

Comment 6

2 years ago
Comment on attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

Approval Request Comment
[Feature/regressing bug #]: Bug 1220720.

[User impact if declined]: EOL honeycomb message points to wrong URL.

[Describe test coverage new/current, TreeHerder]: No automated tests. I didn't test this locally because I don't have a Honeycomb device, but Chenxia will be testing this.

[Risks and why]: Low-risk, URL change.

[String/UUID change made/needed]: None.
Attachment #8701484 - Flags: approval-mozilla-aurora?

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/14aea198d5b1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

let's try that.
Attachment #8701484 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 9

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/ed8fe7294c30
status-firefox45: affected → fixed
You need to log in before you can comment on or make changes to this bug.