Closed Bug 1234733 Opened 4 years ago Closed 4 years ago

Incorrect locale language tag in Honeycomb EOL url

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
fennec 45+ ---

People

(Reporter: liuche, Assigned: Margaret)

References

Details

Attachments

(1 file)

We should use Locales.getLanguageTag(Locale.getDefault()) instead of just Locale.getDefault() in the Honeycomb EOL message.
I see this isn't an issue for the other SUMO URLs we format from Java:
http://hg.mozilla.org/mozilla-central/annotate/35b211eaad1f/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java#l851
http://hg.mozilla.org/mozilla-central/annotate/35b211eaad1f/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#l3373

Maybe we need to move the logic to format these links into some sort of helper method so that we don't make this mistake again.
tracking-fennec: --- → 45+
Assignee: nobody → margaret.leibovic
Attachment #8701484 - Flags: review?(liuche) → review+
Comment on attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

https://reviewboard.mozilla.org/r/28973/#review25735
https://hg.mozilla.org/integration/fx-team/rev/14aea198d5b18b4850801a23c61cbd066bf93f4f
Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche
Comment on attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

Approval Request Comment
[Feature/regressing bug #]: Bug 1220720.

[User impact if declined]: EOL honeycomb message points to wrong URL.

[Describe test coverage new/current, TreeHerder]: No automated tests. I didn't test this locally because I don't have a Honeycomb device, but Chenxia will be testing this.

[Risks and why]: Low-risk, URL change.

[String/UUID change made/needed]: None.
Attachment #8701484 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/14aea198d5b1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8701484 [details]
MozReview Request: Bug 1234733 - Fix locale language tag in Honeycomb EOL url. r=liuche

let's try that.
Attachment #8701484 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.