If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Non-ascii characters in video titles on YouTube lead to UnicodeEncodeError

RESOLVED FIXED

Status

Testing
external-media-tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: maja_zf, Assigned: maja_zf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
>2015-12-22 11:10:41    ERROR -  TEST-UNEXPECTED-ERROR | test_basic_playback.py TestBasicYouTubePlayback.test_video_playing_in_one_tab | UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-6: ordinal not in range(128)
>2015-12-22 11:10:41     INFO -  Traceback (most recent call last):
>2015-12-22 11:10:41     INFO -    File "c:\jenkins\workspace\temp_test-mn-mse-youtube-medium1-60-aurora-win_32_64\build\venv\lib\site-packages\marionette\marionette_test.py", line 344, in run
>2015-12-22 11:10:41     INFO -      testMethod()
>2015-12-22 11:10:41     INFO -    File "c:\jenkins\workspace\temp_test-mn-mse-youtube-medium1-60-aurora-win_32_64\firefox_media_tests\playback\youtube\test_basic_playback.py", line 63, in test_video_playing_in_one_tab
>2015-12-22 11:10:41     INFO -      playback_done)
>2015-12-22 11:10:41     INFO -    File "c:\jenkins\workspace\temp_test-mn-mse-youtube-medium1-60-aurora-win_32_64\build\venv\lib\site-packages\firefox_media_tests\utils.py", line 37, in verbose_until
>2015-12-22 11:10:41     INFO -      str(target)])
>2015-12-22 11:10:41     INFO -    File "c:\jenkins\workspace\temp_test-mn-mse-youtube-medium1-60-aurora-win_32_64\build\venv\lib\site-packages\media_utils\youtube_puppeteer.py", line 368, in __str__
>2015-12-22 11:10:41     INFO -      '\tvideo_title: {0}'.format(self.movie_title),
(Assignee)

Updated

2 years ago
(Assignee)

Comment 1

2 years ago
Created attachment 8701314 [details] [review]
Link to Github pull-request: https://github.com/mjzffr/firefox-media-tests/pull/33
Attachment #8701314 - Flags: review?(spolk)

Comment 2

2 years ago
Comment on attachment 8701314 [details] [review]
Link to Github pull-request: https://github.com/mjzffr/firefox-media-tests/pull/33

LGTM
Attachment #8701314 - Flags: review?(spolk) → review+
(Assignee)

Comment 3

2 years ago
https://github.com/mjzffr/firefox-media-tests/commit/cdd155c1823a1a669246d3b093996fa3eb09dbc8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.