Closed Bug 1234759 Opened 8 years ago Closed 8 years ago

Autophone - phonedash - Add selection to display minimum values

Categories

(Testing Graveyard :: Autophone, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bc, Assigned: bc)

References

()

Details

Attachments

(1 file)

Attached patch min-values.patchSplinter Review
It may be the case that graphing the minimum values instead of the mean values in phonedash may provide a clearer signal for regressions. This patch adds the ability to select either mean or minimum values for the graph. The error bars for the minimum values is set to twice the stderr/stddev and is set to be asymmetric with the errorbar showing the range above the minimum value.

I've loaded the current data from phonedash.mozilla.org into phonedash-dev.allizom.org and applied this patch so that the results can be viewed at http://phonedash-dev.allizom.org/
Attachment #8701341 - Flags: review?(gbrown)
Comment on attachment 8701341 [details] [diff] [review]
min-values.patch

Review of attachment 8701341 [details] [diff] [review]:
-----------------------------------------------------------------

I'm out of my comfort zone here / don't know this code. But it looks fine and works great on http://phonedash-dev.allizom.org.
Attachment #8701341 - Flags: review?(gbrown) → review+
Me too. This is unfamiliar to me as well, but I've modified it enough to know how to add simple things like this. ;-)
https://github.com/markrcote/phonedash/commit/5913c44f1a98953e0814b0a9be8867cf8e669094

deployed to phonedash.mozilla.org and phonedash-dev.allizom.org. you'll need to clear your cache or force reload to get the new version and may need to remove the path to get the new parameter.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
dustin: Did you add the right bug?
Flags: needinfo?(dustin)
nope.  These 7-digit bug numbers kill me.
No longer depends on: 1247343
Flags: needinfo?(dustin)
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: