1234822 - [CID 1242821] unused value

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Franziskus Kiefer [:franziskus]]

In pk11util.c:SECMOD_AddNewModuleEx the result value from PK11_UpdateSlotAttribute is not used.

Comment 1

[Franziskus Kiefer [:franziskus]]

Attachment: Bug1234822.patch

returning if PK11_UpdateSlotAttribute is not successful. Or does the logic require to go through all slots even if one of them fails?

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8701459 [details] [diff] [review]
Bug1234822.patch

Review of attachment 8701459 [details] [diff] [review]:
-----------------------------------------------------------------

::: lib/pk11wrap/pk11util.c
@@ +648,5 @@
>                      if (defaultMechanismFlags & PK11_DISABLE_FLAG) {
>                          PK11_UserDisableSlot(slot);
>                      }
>                  } /* for each slot of this module */
>   		SECMOD_ReleaseReadLock(moduleLock);

Can you provide a patch with enough context to review this please?  Or put it on rietveld.  I notice that you aren't releasing the read lock when this returns, but I can't be sure that it's a problem.

Comment 3

[Franziskus Kiefer [:franziskus]]

Attachment: Bug1234822.patch

right, maybe we also should destroy the module?

patch is also here: https://codereview.appspot.com/284090043/

Comment 4

[Martin Thomson [:mt:]]

Comment on attachment 8703525 [details] [diff] [review]
Bug1234822.patch

Review of attachment 8703525 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the rietveld version.  And the fixup.

Comment 5

[Martin Thomson [:mt:]]

Comment on attachment 8703525 [details] [diff] [review]
Bug1234822.patch

https://hg.mozilla.org/projects/nss/rev/bbf2f8f1a9a4