1234872 - Graphs chooser should only display non-subtests by default

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

Loading the list of tests in the graph chooser is currently unnecessarily slow, it would be a lot faster if we only loaded the tests that weren't summaries by default. For the rare case that the user wanted to select one of those, we could add a checkbox called "Show subtests" (unchecked by default).

This involves both a client side and a server side portion, the latter of which is discussed in bug 1234868.

Comment 1

[MikeLing]

Hi Will, could I work on this issue and bug 1234868 after bug 1226693 been landed? Thank you :)

Comment 2

[William Lachance (:wlach)]

(In reply to MikeLing from comment #1)
> Hi Will, could I work on this issue and bug 1234868 after bug 1226693 been
> landed? Thank you :)

Absolutely, this would be great to have. :) Feel free to start working on it immediately if you like, I hope to land your patches in the second week of February.

Comment 3

[William Lachance (:wlach)]

I'm going to take this now, since it's annoying :jmaher.

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1234872 > mozilla:master

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8746161 [details] [review]
[treeherder] wlach:1234872 > mozilla:master

This was even easier than I expected.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8746161 [details] [review]
[treeherder] wlach:1234872 > mozilla:master

that was pretty simple!

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla/treeherder/commit/e7e98d0155e17198b85a85af2bcb9eaa40d9a44b

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/23598d6015888d59c4786dcc2186a95c70bc1cda
Bug 1234872 - Don't show subtests in performance data chooser by default

Instead have a checkbox that allows us to display them if needed. Most
commonly they are not interesting.