Closed Bug 1234918 Opened 9 years ago Closed 7 years ago

Yosemite - Use OSX vibrancy for Developer Edition theme titlebar

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1386721

People

(Reporter: ntim, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Attachment #8701587 - Flags: ui-review?(hholmes)
Attachment #8701587 - Flags: review?(dao)
Attached patch Patch v1.1Splinter Review
Attachment #8701587 - Attachment is obsolete: true
Attachment #8701587 - Flags: ui-review?(hholmes)
Attachment #8701587 - Flags: review?(dao)
Attachment #8701588 - Flags: review?(dao)
Attachment #8701588 - Flags: ui-review?(hholmes)
We've just turned this off for the default theme, and there are usability changes involved in doing so (cf. bug 1161565).

I'm not convinced we should now turn it on for the devedition theme and revert those changes there. What's the rationale here? (Related: please don't file bugs with no explanation beyond the summary when the summary isn't self-explanatory.)
(In reply to :Gijs Kruitbosch from comment #3)
> We've just turned this off for the default theme, and there are usability
> changes involved in doing so (cf. bug 1161565).
Hmm, strange, I have the tweak applied as an userstyle, and double click to maximize works fine. I'm on El Capitan though.

> I'm not convinced we should now turn it on for the devedition theme and
> revert those changes there. What's the rationale here? (Related: please
> don't file bugs with no explanation beyond the summary when the summary
> isn't self-explanatory.)
Just a visual improvement in my opinion.
(In reply to Tim Nguyen [:ntim] from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > We've just turned this off for the default theme, and there are usability
> > changes involved in doing so (cf. bug 1161565).
> Hmm, strange, I have the tweak applied as an userstyle, and double click to
> maximize works fine. I'm on El Capitan though.
Also works fine with the patch applied.
Attachment #8701588 - Flags: ui-review?(hholmes)
Attachment #8701588 - Flags: review?(dao)
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: