Closed
Bug 1234923
Opened 9 years ago
Closed 9 years ago
Port "Bug 1221459 - Remove TouchCaret and SelectionCarets" and Bug 1210341 - Reduce accessiblecaret size to comm-central
Categories
(Thunderbird :: Installer, defect)
Thunderbird
Installer
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 46.0
People
(Reporter: mkmelin, Assigned: mkmelin)
Details
Attachments
(2 files)
|
3.79 KB,
patch
|
aleth
:
review+
philip.chee
:
review+
|
Details | Diff | Splinter Review |
|
7.73 KB,
patch
|
Details | Diff | Splinter Review |
Port https://hg.mozilla.org/mozilla-central/rev/8c208d26dc1b We're packaging wise busted due to this atm.
Attachment #8701585 -
Flags: review?(philip.chee)
Attachment #8701585 -
Flags: review?(aleth)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8701585 [details] [diff] [review] bugXXX_port_rem_touchcaret.patch I have a working patch too, but you beat me to it. Please replace @RESPATH@/res/text_caret*.* with: +@RESPATH@/res/accessiblecaret.png +@RESPATH@/res/accessiblecaret@1.5x.png +@RESPATH@/res/accessiblecaret@2.25x.png +@RESPATH@/res/accessiblecaret@2x.png +@RESPATH@/res/accessiblecaret_tilt_left.png +@RESPATH@/res/accessiblecaret_tilt_left@1.5x.png +@RESPATH@/res/accessiblecaret_tilt_left@2.25x.png +@RESPATH@/res/accessiblecaret_tilt_left@2x.png +@RESPATH@/res/accessiblecaret_tilt_right.png +@RESPATH@/res/accessiblecaret_tilt_right@1.5x.png +@RESPATH@/res/accessiblecaret_tilt_right@2.25x.png +@RESPATH@/res/accessiblecaret_tilt_right@2x.png This is due to Bug 1210341 changed ua.css from using resource://gre/res/text_caret*.png to resource://gre/res/accessiblecaret*.png See: http://hg.mozilla.org/mozilla-central/rev/56c6ed0b50e4#l17.1 r=me with this change.
Attachment #8701585 -
Flags: review?(philip.chee) → review+
|
|
||
Comment 2•9 years ago
|
||
commit message could be something like: Update package-manifest.in for Bug 1210341 and Bug 1221459 (comm-central part) Bug 1221459 - Remove TouchCaret and SelectionCarets Bug 1210341 - Reduce accessiblecaret size
Flags: needinfo?(mkmelin+mozilla)
|
|
||
Updated•9 years ago
|
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Component: General → Installer
|
|
||
Updated•9 years ago
|
Summary: port "Bug 1221459 - Remove TouchCaret and SelectionCarets" to comm-central → Port "Bug 1221459 - Remove TouchCaret and SelectionCarets" and Bug 1210341 - Reduce accessiblecaret size to comm-central
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8701585 [details] [diff] [review] bugXXX_port_rem_touchcaret.patch Review of attachment 8701585 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! (note comment 1)
Attachment #8701585 -
Flags: review?(aleth) → review+
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/9700246596a0 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(mkmelin+mozilla)
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
You need to log in
before you can comment on or make changes to this bug.
Description
•