1234927 - Add fxheads to `wip` set up from |mach mercurial-setup|

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Andrew Halberstadt [:ahal]]

Recently the firefoxtree extension stopped saving local tags, instead relying on namespace metadata. This meant that it stopped showing up in the |hg wip| command that gets set up by |mach mercurial-setup|.

We should add a new label for fxheads so they show up again.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1234927 - Display fxheads in |hg wip| alias, r=gps

Review commit: https://reviewboard.mozilla.org/r/28991/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28991/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8701595 [details]
MozReview Request: Bug 1234927 - Display fxheads in |hg wip| alias, r=gps

https://reviewboard.mozilla.org/r/28991/#review25819

FWIW, I started a thread on the mercurial-devel list about potentially adding {names} or something similar so we don't have to deal with every namespace as a one off.

::: tools/mercurial/hgsetup/config.py:257
(Diff revision 1)
> +            '{label("log.fxtree", if(fxheads," {fxheads}"))} '

Let's use log.bookmark here because we can't expect people to have this label defined.

Comment 3

[Andrew Halberstadt [:ahal]]

I'm not 100% sure how namespaces work, but isn't the log.fxtree label defined by firefoxtree? This patch works as is for me, both with and without firefoxtree installed. Just without firefoxtree, fxheads don't get displayed in `hg wip` which seems like the correct behaviour.

Or do you mean for purposes of colorization? If that's the case I'd prefer log.tag over log.bookmark.

Comment 4

[Gregory Szorc [:gps]]

label() is used for colorization. We should not invent a new label for this usage.

Comment 5

[Andrew Halberstadt [:ahal]]

Makes sense. I'll switch it to log.tag then, as they act more like tags than bookmarks.

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8701595 [details]
MozReview Request: Bug 1234927 - Display fxheads in |hg wip| alias, r=gps

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28991/diff/1-2/

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/967b246b56b2

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/967b246b56b2