Closed
Bug 1234938
Opened 9 years ago
Closed 8 years ago
Remove DXGL glFinish call
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
DUPLICATE
of bug 1255224
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file)
|
3.04 KB,
patch
|
jgilbert
:
review-
|
Details | Diff | Splinter Review |
To get good performance with DXGL we need to stop using glFinish to sync.
|
Assignee | |
Comment 1•9 years ago
|
||
Please review carefully. I'm particularly unsure if I'm missing the glMakeCurrent in Fence().
My understanding is the keyed mutex wont fence the GL stream so they are required but I can't really confirm this. I don't see how the keyed mutex however would know anything about the GL pipeline so they seem like the right thing to do (tm).
Looks like we no longer call the _ContentThread variant. The non _ContentThread varient were using the GLContext (doing flush/finish) so I presume the GLContext is fine to use from these function to issue a proper fence.
Attachment #8701615 -
Flags: review?(jgilbert)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → bgirard
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8701615 [details] [diff] [review]
patch
Review of attachment 8701615 [details] [diff] [review]:
-----------------------------------------------------------------
I simplified the fencing APIs, so please rebase.
Attachment #8701615 -
Flags: review?(jgilbert) → review-
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•