1234954 - Running ./mach bootstrap fails parsing Mercurial version ("3.6-rc")

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Yury Delendik (:yury)]

After running `./mach bootstrap` and choosing Desktop and MacPort it shows the following:

Executing as root: sudo /opt/local/bin/port select --set python python27
Password:
Selecting 'python27' for 'python' succeeded. 'python27' is now active.
Error running mach:

    ['bootstrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ValueError: invalid version number '3.6-rc'

  File "/Users/yury/Work/mozilla-central/python/mozboot/mozboot/mach_commands.py", line 23, in bootstrap
    bootstrapper.bootstrap()
  File "/Users/yury/Work/mozilla-central/python/mozboot/mozboot/bootstrap.py", line 139, in bootstrap
    self.instance.ensure_mercurial_modern()
  File "/Users/yury/Work/mozilla-central/python/mozboot/mozboot/base.py", line 300, in ensure_mercurial_modern
    installed, modern, version = self.is_mercurial_modern()
  File "/Users/yury/Work/mozilla-central/python/mozboot/mozboot/base.py", line 295, in is_mercurial_modern
    our = StrictVersion(match.group(1))
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/version.py", line 40, in __init__
    self.parse(vstring)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/version.py", line 107, in parse
    raise ValueError, "invalid version number '%s'" % vstring


(Bug filed because it asked me too :)

Comment 1

[Yury Delendik (:yury)]

Reported mercurial version is:

$ hg --version
Mercurial Distributed SCM (version 3.6-rc+20-6474b64045fb)

Comment 2

[Gregory Szorc [:gps]]

I thought this was fixed over a year ago :/

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/235dcd7acb6cf43fed439c1d49afe57fbce34354
Bug 1234954 - Use LooseVersion for parsing Mercurial version; r=me

Comment 4

[Gregory Szorc [:gps]]

We had fixed the Python version parsing in bug 1111256, little over a year ago in 48786ef504ff.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/235dcd7acb6c