1234961 - Validate puppet changes with travis

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

This is not easily able to be all-inclusive, but we should catch actual validation and linting errors earlier and alert on it. Even allowing a chance to do so without an immediate merge to production.

I did this via a github PR, even though I'd land it directly to hg. Its easiest reviewed via the individual commits not as one-big-change.

(This became a thing for me after getting a puppet parse error again today, and having had this partially done in github for months)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Ah, I didn't see this when I commented on the PR.

Comment 2

[Justin Wood (:Callek)]

Attachment: Github PR version of patch

...interestingly I filed and tried to set Github's PR and a review on :rail for this. But since dustin is reviewing in the PR itself I might as well do this.

I plan to land in individual hg patches, fwiw.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8702271 [details] [review]
Github PR version of patch

Comments in https://github.com/mozilla/build-puppet/pull/4

Comment 4

[Justin Wood (:Callek)]

Landed with:

https://hg.mozilla.org/build/puppet/rev/f9d66cdefd2f
https://hg.mozilla.org/build/puppet/rev/670c9bc8321d
https://hg.mozilla.org/build/puppet/rev/bb8e0793da72
https://hg.mozilla.org/build/puppet/rev/220b138f98f6
https://hg.mozilla.org/build/puppet/rev/76ae0bd1c571
https://hg.mozilla.org/build/puppet/rev/db4f8122a6fd

Not yet merged to production

Comment 5

[Justin Wood (:Callek)]

And its live now.