1235030 - [camera][nexus6-l] can't record video, preview and taking picture are fine.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Farmer Tseng[:fatseng](inactive)]

Attachment: camera.log

can't record video, preview and taking picture are fine.

Comment 1

[Farmer Tseng[:fatseng](inactive)]

Description:
can't record video

Pre-requisite: N/A

Repro Steps:
1) launch camera app


Actual:
can't record a video

Expected:
The user is able to record a video.

Repro Rates: 100%
See attached: logcat (timestamp is around 12-1 03:38)

Comment 2

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

12-25 04:49:52.200   342   629 W GraphicBufferAllocator: alloc(1920, 1080, 34, 00030022, ...) failed -22 (Invalid argument)

Comment 3

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Farmer,

Per the log, QCOM_BSP is not defined.

status_t GraphicBufferAllocator::alloc(uint32_t w, uint32_t h,
                                       PixelFormat format, int usage,
                                       buffer_handle_t* handle,
                                       int32_t* stride, uint32_t bufferSize)
{
    ATRACE_CALL();
    // make sure to not allocate a N x 0 or 0 x N buffer, since this is
    // allowed from an API stand-point allocate a 1x1 buffer instead.
    if (!w || !h)
        w = h = 1;

    // we have a h/w allocator and h/w buffer is requested
    status_t err;
#ifdef QCOM_BSP
    if(bufferSize) {
        err = mAllocDev->allocSize(mAllocDev, w, h,
                               format, usage, handle, stride, bufferSize);
    } else {
        err = mAllocDev->alloc(mAllocDev, w, h, format, usage, handle, stride);
    }
    ALOGW_IF(err, "alloc(%u, %u, %d, %08x, %d ...) failed %d (%s)",
            w, h, format, usage, bufferSize, err, strerror(-err));
#else
    err = mAllocDev->alloc(mAllocDev, w, h, format, usage, handle, stride);
    ALOGW_IF(err, "alloc(%u, %u, %d, %08x, ...) failed %d (%s)",
            w, h, format, usage, err, strerror(-err));
#endif

Comment 4

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

After enabling VENUS_COLOR_FORMAT, camera recording & video playback functions well.

Comment 5

[Farmer Tseng[:fatseng](inactive)]

Attachment: enable VENUS_COLOR_FORMAT and MDSS_TARGET

Hi Michael, Android doesn't support is-board-platform-in-list, replace it by filter.

Comment 6

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

M release also use filter. I have no concern.

Comment 7

[Farmer Tseng[:fatseng](inactive)]

Attachment: for b2g-5.1.1_r29

Comment 8

[Michael Wu [:mwu]]

Comment on attachment 8703484 [details] [review]
enable VENUS_COLOR_FORMAT and MDSS_TARGET

Assuming this PR isn't needed anymore due to the new one for the newer branch. If it's still necessary, please rerequest review.

Comment 9

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8703484 [details] [review]
enable VENUS_COLOR_FORMAT and MDSS_TARGET

Nexus-6-l.xml point to b2g-5.1.0_r1 branch now.
Therefore, it still needs you to review.

Comment 10

[Farmer Tseng[:fatseng](inactive)]

checkin-needed
Please help merge code.
Thanks.

Comment 11

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/hardware_qcom_display/commit/7b5967bbd90cb193b489d8f8668bc945384bd9b1
https://github.com/mozilla-b2g/hardware_qcom_display/commit/9312b15e14ee19686ec7eac7b4cf2035199e92a6