Closed Bug 1235099 Opened 5 years ago Closed 5 years ago
Remove the NS
_APP _BOOKMARKS _50 _FILE directory service key
Nothing in mozilla-central uses the NS_APP_BOOKMARKS_50_FILE/BMarks key except tests. It's also not been very useful since the switch to places in ... Firefox 3? so even if addons use it, it's not doing them much good. BookmarkHTMLUtils.defaultPath returns the same thing anyways for those that really do insist on getting the equivalent thing (but I'd argue BookmarkHTMLUtils.defaultPath, as well as the browser.bookmarks.file pref could just go away as well). Seamonkey does use NS_APP_BOOKMARKS_50_FILE/BMarks, but they really only need the #define, which they can add in their source.
Err, did you attach the right patch? It doesn't touch NS_APP_BOOKMARKS_50_FILE at all.
That was, indeed, the wrong patch.
Attachment #8703940 - Flags: review?(dolske) → review+
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in before you can comment on or make changes to this bug.