Closed
Bug 1235105
Opened 8 years ago
Closed 8 years ago
Add integration test: |lockscreen_unlock_handler_test.js|
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gweng, Assigned: gweng)
Details
Attachments
(1 file)
It should contain such tests: ## Unlock handler ---- Set NO password then lock the device -> Slide to the handler -> [*Show home screen] Press the power button -> [*Panel dismissed] && [*Slider reset] ---- Set password then lock the device -> Slide to the handler -> [*Show the password panel] -> Press the power button -> [*Panel dismissed] && [*Slider reset] ----
Assignee | ||
Comment 1•8 years ago
|
||
Well, in fact these tests are already in Gaia repo. However, this is for the plan to collect all similar tests at once, and to implement them by the component. So only when the organization of these tests matters this is a must-have feature.
Assignee | ||
Comment 2•8 years ago
|
||
Or, we should focus on the UI check part, which was not addressed in the previous tests. So even though most of these code will be duplicated, and the flow is almost the same, we can still test different items in our concern.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gweng
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8701910 [details] [review] [gaia] snowmantw:bug1235105 > mozilla-b2g:master It works well on the TaskCluster so I set the review. https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e199ed03426ae7c5812efe6b7bd65e65f5426df8
Attachment #8701910 -
Flags: review?(timdream)
Updated•8 years ago
|
Attachment #8701910 -
Flags: review?(timdream) → review+
Assignee | ||
Comment 5•8 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/0fac66f5d43933e391642ceed35749795ce0565f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•