Closed Bug 1235107 Opened 8 years ago Closed 8 years ago

Default bookmarks are not localized when using langpacks and intl.locale.matchOS

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

STR:
- Install Firefox with a locale that is *not* the one of your desktop environment
- Download a langpack for the locale of your desktop environment from wherever they are distributed from (I think it's AMO for releases, they are in latest-mozilla-central-l10n/<platform>/xpi for nightlies)
- Put the langpack xpi in the browser/extensions directory in the Firefox directory, renaming it to <its em:id>.xpi (langpack-<lang>@firefox.mozilla.org.xpi)
- Create a browser/defaults/preferences/foo.js with the following content:
    pref("extensions.autoDisableScopes", 11);
    pref("intl.locale.matchOS", true);
(that's a typical setup you can find on Linux distros, and how they use langpacks to provide localized Firefox)
- Open Firefox with a fresh profile

Actual result:
- The started Firefox are in the locale of your desktop environment/langpack, and the bookmarks in the locale from the original Firefox download.

Expected result:
- Localized bookmarks
Note this has the nice side effect of allowing to move bookmarks.html installation to jar.mn in a followup bug I'm about to file.
Assignee: nobody → mh+mozilla
Attachment #8701912 - Flags: review?(dolske)
Blocks: 1235108
Just in case, I double checked that some tests do turn red if the bookmark url doesn't work.
Comment on attachment 8701912 [details] [diff] [review]
Move bookmarks.html to a chrome localized location

Review of attachment 8701912 [details] [diff] [review]:
-----------------------------------------------------------------

Seems ok. For some reason moving it to chrome:// is making me a little twitchy, but I can't think of any reason why that's a problem. I even sorta wonder why the other default profile files are not just done the same way.
Attachment #8701912 - Flags: review?(dolske) → review+
(In reply to Justin Dolske [:Dolske] from comment #3)
> I even sorta wonder why the other default profile files are not just done the same way.

I'm proposing to remove them in bug 1234012.
https://hg.mozilla.org/mozilla-central/rev/21e3cdc18595
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: