1235151 - Stop using -I for defines.inc in toolkit/library/l10n.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Factor all the install.rdfs used for langpacks

The only difference between all of them is the application id they target.
Interestingly, the Fennec one is still targetting the XUL appid, instead
of the Android one, which doesn't seem right.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Use #include in toolkit/locales/generic/install.rdf instead of -I on the preprocessor command line

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8701999 [details] [diff] [review]
Factor all the install.rdfs used for langpacks

LGTM - nalexander, I assume fixing the appid for Android here won't break anything?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b87f6584f8a0
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d454d2bb20e

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Shal [:mshal] from comment #3)
> Comment on attachment 8701999 [details] [diff] [review]
> Factor all the install.rdfs used for langpacks
> 
> LGTM - nalexander, I assume fixing the appid for Android here won't break
> anything?

I doubt it but I know little here.  Redirecting to mfinkle, who may know more.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b87f6584f8a0
https://hg.mozilla.org/mozilla-central/rev/4d454d2bb20e

Comment 7

[Axel Hecht [:Pike]]

Due to android being android, we can't do language packs in their real sense. Not sure if there's any use case to have those for fennec at all these days?

Comment 8

[Nick Alexander :nalexander [he/him]]

Clearing mfinkle's NI, since this landed and nothing's borked.

Comment 9

[Nick Alexander :nalexander [he/him]]

(In reply to Axel Hecht [:Pike] from comment #7)
> Due to android being android, we can't do language packs in their real
> sense. Not sure if there's any use case to have those for fennec at all
> these days?

I think you're correct, this isn't really used.  The only references I see to defines.inc in mobile/ are in scripts working around mobile/android -- https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile+%22defines.inc%22&redirect=true&case=false

After that, the references are in https://dxr.mozilla.org/mozilla-central/source/toolkit/locales/l10n.mk in the langpack-* targets, which probably don't get invoked for Android.  So we should be able to cull some of these work-arounds.  I think that's a separate ticket that removes work-arounds and ensures that langpack-* targets fail for Fennec and b2gdroid.