Implement "Real Order Received" as a sorting mechanism

RESOLVED INVALID

Status

--
enhancement
RESOLVED INVALID
3 years ago
3 years ago

People

(Reporter: bj, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [dupme])

(Reporter)

Description

3 years ago
Sorting by the order received is very useful, but the current Order Received column is useless as it obfuscates the order whenever a folder is compacted. (See bug 484795.)

It would be nice to have a real "order received" field in Thunderbird.

Updated

3 years ago
Whiteboard: [dupme]

Comment 1

3 years ago
Yes, please, please, please!

I won't even suggest the things I'm thinking about the parentage of the person (or persons) who thought that using the buffer address for an order received index would be a clever idea, but I hope he, she, or they are in rehab by now.

Fixing this shouldn't be hard if you have a place to save an int that would be the current highest order received index.  Then when a new message comes in you increment it by one (++) and set the new message's order received index to it.  When the folder is compacted go through all the remaining messages in order received index order and assign a new index, finally resetting the highest order received index.

I apologize for being so snarky, but this bug is really, really bad and shouldn't be hard to fix for someone who knows their way around the code...

Best,
    -=P=-

Comment 2

3 years ago
So how would this new "order received work"? Some global counter incremented for each message? A global for all accounts? Or a global per account? But you can mix messages from multiple account into one folder.
Also, is "date received" (not Message date) NOT enough of an ordering mechanism?
(Reporter)

Comment 3

3 years ago
(In reply to :aceman from comment #2)
> So how would this new "order received work"? Some global counter incremented
> for each message? A global for all accounts? Or a global per account? But
> you can mix messages from multiple account into one folder.

Real order placed in this folder would also work.

> Also, is "date received" (not Message date) NOT enough of an ordering
> mechanism?

I've tried it. Bad time zone settings, bad server configurations, message header errors, and spam with bogus times cause messages to appear our of order and occasional new messages to be hidden back in the middle or older messages.

I like Inbox Zero in theory but in practice it doesn't happen. I want a way to see new messages before they get buried among the old.

Comment 4

3 years ago
(In reply to B.J. Herbison from comment #3)
> (In reply to :aceman from comment #2)
> > So how would this new "order received work"? Some global counter incremented
> > for each message? A global for all accounts? Or a global per account? But
> > you can mix messages from multiple account into one folder.
> 
> Real order placed in this folder would also work.

Then what is the different to the current "order received" implemented via the message key, which is a monotonically increasing counter. It WAS the offset into the file holding the messages but was changed to be incremented by one. Should be out in TB45. This one should survive compacts. The numbers will only change if you rebuild (repair) the folder. Or if you move message to another folder, its key will change.

> > Also, is "date received" (not Message date) NOT enough of an ordering
> > mechanism?
> 
> I've tried it. Bad time zone settings, bad server configurations, message
> header errors, and spam with bogus times cause messages to appear our of
> order and occasional new messages to be hidden back in the middle or older
> messages.

What you describe is the message Date (a header put into the message by the sender). I say about the "Received" column that you can enable in the message list. I think that one should be the date you have received it into TB. It should not be bogus.
(Reporter)

Comment 5

3 years ago
(In reply to :aceman from comment #4)

> Then what is the different to the current "order received" implemented via
> the message key, which is a monotonically increasing counter. It WAS the
> offset into the file holding the messages but was changed to be incremented
> by one. Should be out in TB45. This one should survive compacts. The numbers
> will only change if you rebuild (repair) the folder. Or if you move message
> to another folder, its key will change.

I'm sorry I didn't know about this future Thunderbird behavior when I created this bug report. What is the bug number for this change?

Comment 6

3 years ago
Yeah, it should be in bug 1183490.
(Reporter)

Comment 7

3 years ago
Given the change in bug 1183490 the Order Received will be "Real Order Received" so there is no need for a new column.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.