Closed Bug 1235181 Opened 4 years ago Closed 4 years ago

Move the rule view into the Inspector directory

Categories

(DevTools :: Inspector: Rules, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: gl, Assigned: gl)

References

Details

Attachments

(3 files, 1 obsolete file)

No description provided.
Depends on: 1235178
Blocks: 1235172
Comment on attachment 8703373 [details] [diff] [review]
Part 1: Move the Rules Inspector into its own directory [1.0]

Review of attachment 8703373 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, granted we resolve the discussion about naming.
Attachment #8703373 - Flags: review?(pbrosset) → review+
Comment on attachment 8703379 [details] [diff] [review]
Part 2: Move the Rules Inspector tests into its own directory [2.0]

Review of attachment 8703379 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
As discussed earlier today, we agreed on moving computedview and ruleview as sub-folders of the inspector folder.
Could you send an email to the devtools mailing list about this change?
Also, maybe some names in /devtools/docs/inspector-panel.md should be changed.
We'll also need a bug filed to get rid of what remains in the styleinspector folder.
Attachment #8703379 - Flags: review?(pbrosset) → review+
Attachment #8704345 - Flags: review?(pbrosset)
Attachment #8704345 - Flags: review?(pbrosset) → review+
Summary: Move the rule view into its own directory → Move the rule view into the Inspector directory
https://hg.mozilla.org/mozilla-central/rev/0f6190c61371
https://hg.mozilla.org/mozilla-central/rev/bb7315acc330
https://hg.mozilla.org/mozilla-central/rev/4c26a7375cda
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS				Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.