Closed
Bug 1235201
Opened 8 years ago
Closed 8 years ago
Make W^X work in Win64 browser builds
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
1.78 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Win64 browser builds (not shell builds) allocate an extra page to store the exception handler record that needs to be made writable before we can initialize it. The simplest fix is to add an additional VirtualProtect call. It might be possible in some cases to get away with one VirtualProtect call at the end, but I don't think it's worth the complexity.
Attachment #8702060 -
Flags: review?(luke)
|
||
Updated•8 years ago
|
Attachment #8702060 -
Flags: review?(luke) → review+
|
||
Comment 2•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9dbd4fd0de1f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•