Closed
Bug 1235212
Opened 8 years ago
Closed 8 years ago
[css-grid] Use Unicode ellipsis in error messages
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(1 file)
|
1.78 KB,
patch
|
flod
:
review+
|
Details | Diff | Splinter Review |
Follow-up from bug 1118820 comment #67: > PEMoreThanOneGridRepeatAutoFillInNameList=Only one repeat(auto-fill, ...) is > allowed in a name list for a subgrid. > PEMoreThanOneGridRepeatAutoFillFitInTrackList=Only one repeat(auto-fill, > ...) or repeat(auto-fit, ...) is allowed in a track list. > PEMoreThanOneGridRepeatTrackSize=Only one track size is allowed inside > repeat(auto-fit/auto-fill, ...). > > I suppose '...' must be intended as a generic ellipsis and not part of the > syntax: in that case it would be useful to use … (one Unicode character) for > consistency with the other strings in Mozilla products. Also no need to use > new string IDs for the change.
|
Assignee | |
Comment 1•8 years ago
|
||
Does this look OK?
Attachment #8702078 -
Flags: review?(francesco.lodolo)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8702078 [details] [diff] [review] fix Review of attachment 8702078 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #8702078 -
Flags: review?(francesco.lodolo) → review+
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2c26039e85f0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•