123523 - splash screen grabs too many colors

Status: RESOLVED WORKSFORME

(SeaMonkey :: UI Design, defect)

Description

[Colin Blake]

The splash screen uses all my colors!!

Mozilla 0.9.8 on OpenVMS (UNIX build), using X11/MOTIF (GTK). 256 colors.

If I start Mozilla using the new -splash option, the main Mozilla comes up and
looks awful (hardly any colors and VERY dithered looking). I assume that Mozilla
grabbed just about all the available colormaps for the splash screen, and then
by the time it gave them back, it was too late for the main window.

Comment 1

[Arthur]

Could get fixed along with bug 32501. I think the workaround is to obvious for a
release note. Does anyone see this for low colour resolutions on other platforms?

Comment 2

[Colin Blake]

Bug 32501 is about the splash screen looking bad dithered. That is not the 
problem I'm reporting. The splash screen looks good, it the Mozilla window that 
looks crappy.

Comment 3

[Arthur]

Yes, but using less colours in the splash screen could solve both bugs.

Comment 4

[Blake Ross]

splash -> law

Comment 5

[Bill Law]

unix splash->bryner

Sorry, Brian.

Comment 6

[Brian Ryner (not reading)]

Attachment: patch

I'm not positive this is what's causing the problem, but it appears that I'm
leaking the pixmap used for the splash screen.	Could you try applying this
patch and see if it fixes the problem?

Comment 7

[Colin Blake]

Results of using patch from attachment 68518 [details] [diff] [review]

The good news. The main window appeared normal. 

The bad news. The splash screen was trashed. It looked like the color map got 
switched on it or something like that. You could see it was the right image, but 
the colors were all wrong.

No cigar for this one :-)

Comment 8

[Brian Ryner (not reading)]

CC'ing syd, who knows something about X pixmaps and colormaps.  any idea what
could be going on here?

(I'm of the opinion that we should check in this patch anyway since it fixes a leak)

Comment 9

[Brian Ryner (not reading)]

I filed a new bug, 124817, about the leak.  When that's checked in, the symptoms
of this bug will change to what you just described.

Comment 10

[Brian Ryner (not reading)]

Attachment: patch #2

Colin, can you test this patch and let me know what happens?

Comment 11

[Colin Blake]

Patch #2 doesn't change the original symptom, ie. splash screen looks good but 
then the browser window is dithered. Sorry :-(

Comment 12

[Colin Blake]

With the new splash screen in 1.3, I don't see this problem any more. Closing.