1235233 - Fix -Wimplicit-fallthrough warning in intl/uconv/

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: intl_MOZ_FALLTHROUGH.patch

Fix clang's -Wimplicit-fallthrough warning (not yet enabled by default in mozilla-central) about switch cases that fall through without a break or return statement. The warnings can be suppressed with the MOZ_FALLTHROUGH, a MFBT macro for a clang compiler annotation. MOZ_FALLTHROUGH is only needed on cases that have code:

switch (foo) {
  case 1: // These cases have no code. No fallthrough annotations are needed.
  case 2:
  case 3:
    foo = 4; // This case has code, so a fallthrough annotation is needed:
    MOZ_FALLTHROUGH;
  default:
    return foo;
}

intl/uconv/ucvja/nsJapaneseToUnicode.cpp:340:11 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7752a04d13ad

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7752a04d13ad