1235236 - Fix -Wimplicit-fallthrough warning in modules/libjar/

Status: RESOLVED FIXED

(Core :: Networking: JAR, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: libjar_MOZ_FALLTHROUGH.patch

modules/libjar/nsJARInputStream.cpp:112:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels

This patch fixes a clang -Wimplicit-fallthrough warning (not yet enabled by default in mozilla-central) about switch cases that fall through without a break or return statement. Warnings about intentional fallthroughs can be suppressed with MOZ_FALLTHROUGH, a MFBT macro for a clang compiler annotation. MOZ_FALLTHROUGH is only needed on cases that have code:

switch (foo) {
  case 1: // These cases have no code. No fallthrough annotations are needed.
  case 2:
  case 3:
    foo = 4; // This case has code, so a fallthrough annotation is needed:
    MOZ_FALLTHROUGH;
  default:
    return foo;
}

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8702098 [details] [diff] [review]
libjar_MOZ_FALLTHROUGH.patch

Review of attachment 8702098 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks!

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96ce3bd0b806

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/96ce3bd0b806