Closed Bug 1235246 Opened 4 years ago Closed 4 years ago

crash in java.lang.NullPointerException: Null native pointer at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)

Categories

(Firefox for Android :: General, defect, critical)

Unspecified
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: wgianopoulos, Assigned: jchen)

Details

(Keywords: crash)

Crash Data

Attachments

(3 files)

This bug was filed from the Socorro interface and is 
report bp-a4640ba0-0617-42fc-a2e5-6bf542151227.
=============================================================
Assignee: nobody → nchen
Status: NEW → ASSIGNED
GeckoThread.queueNativeCallLocked tries to execute a queued native call
if it's already overdue, but it incorrectly checked that the queue is
not empty. That check is not necessary, and an overdue native call
should always be executed. One-line patch, r=me.
Attachment #8703023 - Flags: review+
Only three GLController events -- CreateCompositor, PauseCompositor, and
OnResumedCompositor should be prioritized through GLControllerEvent. The
other GLController events should follow the normal event queue ordering
to prevent race conditions.
Attachment #8703024 - Flags: review?(snorp)
LayerView used to call GeckoLayerClient.onGeckoReady directly if Gecko
is sufficiently loaded. However, onGeckoReady indirectly calls
GLController.createCompositor, and it's possible for the
createCompositor event to be prioritized so that it happens before we
initialize GLController, causing a crash. This patch moves the
onGeckoReady call to the Gecko thread, after GLController is
initialized, to avoid this race condition.
Attachment #8703025 - Flags: review?(snorp)
Attachment #8703024 - Flags: review?(snorp) → review+
Attachment #8703025 - Flags: review?(snorp) → review+
I am not sure why I always find things like this over Holidays.  Sorry for that. I know it takes longer to fix them. But then, but then I do have this antiquated old Samsung Galaxy Tab 2 that I am using that is slower than anything else so seems to find these kind of odd race conditions.
(In reply to Bill Gianopoulos [:WG9s] from comment #4)
> I am not sure why I always find things like this over Holidays.  Sorry for
> that. I know it takes longer to fix them. But then, but then I do have this
> antiquated old Samsung Galaxy Tab 2 that I am using that is slower than
> anything else so seems to find these kind of odd race conditions.

No, it's good that you found it! I'm sure a lot of users are encountering it based on the crash volume.
https://hg.mozilla.org/mozilla-central/rev/014d0b989ace
https://hg.mozilla.org/mozilla-central/rev/bd5bcf200648
https://hg.mozilla.org/mozilla-central/rev/6691a39fbeb8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Jim - This crash is #8 on Fx44b8. Should we be uplifting this?
Flags: needinfo?(nchen)
Not this particular bug but I think bug 1236643 will help (different bug but same crash signature)
Flags: needinfo?(nchen)
You need to log in before you can comment on or make changes to this bug.