Closed Bug 1235254 Opened 7 years ago Closed 7 years ago
Importing patches from Moz
Review doesn't seem to pick up new binary files
58 bytes, text/x-review-board-request
STR: - Go to https://reviewboard.mozilla.org/r/24923/ - Copy the "import" command for the changeset ("hg import https://reviewboard-hg.mozilla.org/gecko/rev/c77a60b0b2584c717e7c9083365c72bff1196d27") - Run that command on a local hg repo to import the changeset - Look for the dom/browser-element/mochitest/audio.ogg file on your local filesystem Expected: - File exists Actual: - File doesn't exist Alastor has a try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbf71215f61e with what I believe is the same changeset, importing that cset provides the required file.
Review commit: https://reviewboard.mozilla.org/r/29325/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/29325/
Attachment #8703221 - Flags: review?(smacleod)
Comment on attachment 8703221 [details] MozReview Request: ansible/hg-reviewboard: render git diffs (bug 1235254); r?smacleod https://reviewboard.mozilla.org/r/29325/#review26221 I don't believe this will effect diff generation at all. (context expansion doesn't hit the mercurial server, the context is already stored on Review Board. Review Board doesn't actually fetch diffs from the mercurial server - they're uploaded - what it fetches is base file contents to apply the uploaded diffs.
Attachment #8703221 - Flags: review?(smacleod) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.