1235270 - Set submitter_id before calling _check_data()

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Mahdi Mokhtari]

User Agent: Mozilla/5.0 (X11; FreeBSD i386) AppleWebKit/535.22+ (KHTML, like Gecko) Chromium/17.0.963.56 Chrome/17.0.963.56 Safari/535.22+ Epiphany/2.30.6

Steps to reproduce:

tried to print submitter_id accessed via attachement attributes


Actual results:

printing submitter_id via attachement attributes returns empty object


Expected results:

it should return sumbitter id

Comment 1

[Frédéric Buclin]

The point is that we call the hook in Bugzilla::Attachment::_check_data() before setting submitter_id, and so submitter_id is still undefined when the hook is called. This is not a big deal, because the extension can access the user ID with Bugzilla->user->id. But defining submitter_id before calling _check_data() is safe.

Comment 2

[Mahdi Mokhtari]

Attachment: patch for Bugzilla/Attachment.pm

Patch that fixes this issue (tnx from LpSolit :D)

Comment 3

[Frédéric Buclin]

Comment on attachment 8702145 [details] [diff] [review]
patch for Bugzilla/Attachment.pm

>+    $params->{creation_ts} ||= Bugzilla->dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
>+    $params->{modification_time} = $params->{creation_ts};
>+    $params->{submitter_id} = Bugzilla->user->id || ThrowUserError('invalid_user');

Hum no, only move submitter_id here. Leave the other two where they are currently. They will be set when the attachment is ready to be uploaded.

Comment 4

[Mahdi Mokhtari]

Attachment: newer patch for Bugzilla/Attachment.pm

Comment 5

[Frédéric Buclin]

Comment on attachment 8702147 [details] [diff] [review]
newer patch for Bugzilla/Attachment.pm

>+    #moved for fixing bug #1235270

This comment is useless and should be removed on checkin. Otherwise your patch is ok, so r=LpSolit. Thanks for the patch! :)

Comment 6

[Mahdi Mokhtari]

Attachment: even newer patch for Bugzilla/Attachment.pm

removed extra comment in patch.

Comment 7

[Frédéric Buclin]

Comment on attachment 8702149 [details] [diff] [review]
even newer patch for Bugzilla/Attachment.pm

r=LpSolit

Comment 8

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   7829cc8..66e373d  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   f729352..6e6093a  5.0 -> 5.0