Closed Bug 1235300 Opened 6 years ago Closed 6 years ago

[GijTV] Smart system has to set the ready-state attribute to let JSMarionette know ready to test

Categories

(Testing Graveyard :: JSMarionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fischer, Assigned: Fischer)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file, 2 obsolete files)

46 bytes, text/x-github-pull-request
lchang
: review+
Details | Review
JSMarionette knows the system is ready for testing and launches tests by waiting the ready-state attribute set to 'fullyLoaded' on the system's document.body.
Now the phone system calls document.body.setAttribute('ready-state', 'fullyLoaded') after the launcher is loaded.
The TV system also needs to call document.body.setAttribute('ready-state', 'fullyLoaded') after the homescreen is loaded so Gijtv tests could be run.
Assignee: nobody → fliu
Blocks: 1234482, 1234484, 1231460
No longer blocks: 1231448
No longer depends on: 1234482
Blocks: 1231448
Comment on attachment 8702192 [details] [review]
[gaia] Fischer-L:bug_1235300-set-ready-state-for-JSMarionette > mozilla-b2g:master

@Luke,
This patch makes the TV system call document.body.setAttribute('ready-state', 'fullyLoaded') to let JSMarionette know ready to test.
It also re-enables the app_modal_dialog_test.js to verify the Gijtv test runs normally.
Thank you.
Attachment #8702192 - Flags: review?(lchang)
Comment on attachment 8702192 [details] [review]
[gaia] Fischer-L:bug_1235300-set-ready-state-for-JSMarionette > mozilla-b2g:master

Looks good. Thanks.
Attachment #8702192 - Flags: review?(lchang) → review+
Ever since this landed [1], Gij has looked really flaky on gaia-master [2]. Fischer, can you take a look?

1.) https://treeherder.mozilla.org/#/jobs?repo=gaia-master&revision=c17216015df9
2.) https://treeherder.mozilla.org/#/jobs?repo=gaia-master
Flags: needinfo?(fliu)
I'm going to back this out for now since I don't want people to think that all the blues in GijTV is normal.

reverted in master: https://github.com/mozilla-b2g/gaia/commit/209a027cdb55f6bfa47447d845d509db58c8df4e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(fliu)
Depends on: 1236723
Attached file PR #33762 (obsolete) —
@Luke,
The bug 1236723 has fixed the over-run GijTV issue. I have tried 5 times of tests in the PR #33762 and the test results are all passed.
This patch is to re-enable GijTV tests.
It does:
* Make the smart system call document.body.setAttribute('ready-state', 'fullyLoaded') to let JSMarionette know ready to test.
* Modify the core.js to use Promise
* Modify the tv_apps/smart-system/test/marionette/app_modal_dialog_test.js, tv_apps/smart-system/test/marionette/browser_context_menu_test.js and tv_apps/smart-system/test/marionette/lib/system.js based on other phone Gij test examples
Thank you

@Evan,
Could you please take a look at the following scripts about marionette testing:
tv_apps/smart-system/test/marionette/app_modal_dialog_test.js
tv_apps/smart-system/test/marionette/browser_context_menu_test.js
tv_apps/smart-system/test/marionette/lib/system.js
Thank you
Attachment #8702192 - Attachment is obsolete: true
Attachment #8704511 - Flags: review?(lchang)
Attachment #8704511 - Flags: feedback?(evan)
Comment on attachment 8704511 [details] [review]
PR #33762

LGTM, but has some nits.
Attachment #8704511 - Flags: feedback?(evan) → feedback+
Comment on attachment 8704511 [details] [review]
PR #33762

Looks good! Just don't forget to address Evan's comments. Thanks.
Attachment #8704511 - Flags: review?(lchang) → review+
Attached file PR #31627-2
@Luke,

The smart-dialog has been updated to close dialog on Backspace key not Esc key any more in the commit [1].
So I update browser_context_menu_test.js again to test pressing backspace after menu shown.

I also update the tests based on Evan's comments.

The tests of this update have been run 5 times as well and all passed.

Please have a look, thank you

[1] https://github.com/smart-components/smart-dialog/commit/711a71436522d212e7f54213edfa475bf05d0de0
Attachment #8704511 - Attachment is obsolete: true
Attachment #8707853 - Flags: review?(lchang)
Blocks: 1242887
@Luke,
The patch has been updated to split tests to open only the app_modal_dialog_test.js first ,thank you
Depends on: 1244033
Comment on attachment 8707853 [details] [review]
PR #31627-2

Looks good. Only one comment left on GitHub. Thanks.
Attachment #8707853 - Flags: review?(lchang) → review+
Land to master: https://github.com/mozilla-b2g/gaia/commit/193f5bf74105e108ba7648722f01ce8a65f8eaba
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
No longer depends on: 1244033
Blocks: 1250780
No longer blocks: 1250780
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.