Closed
Bug 1235300
Opened 8 years ago
Closed 8 years ago
[GijTV] Smart system has to set the ready-state attribute to let JSMarionette know ready to test
Categories
(Testing Graveyard :: JSMarionette, defect)
Testing Graveyard
JSMarionette
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Fischer, Assigned: Fischer)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file, 2 obsolete files)
JSMarionette knows the system is ready for testing and launches tests by waiting the ready-state attribute set to 'fullyLoaded' on the system's document.body. Now the phone system calls document.body.setAttribute('ready-state', 'fullyLoaded') after the launcher is loaded. The TV system also needs to call document.body.setAttribute('ready-state', 'fullyLoaded') after the homescreen is loaded so Gijtv tests could be run.
Assignee | ||
Updated•8 years ago
|
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8702192 [details] [review] [gaia] Fischer-L:bug_1235300-set-ready-state-for-JSMarionette > mozilla-b2g:master @Luke, This patch makes the TV system call document.body.setAttribute('ready-state', 'fullyLoaded') to let JSMarionette know ready to test. It also re-enables the app_modal_dialog_test.js to verify the Gijtv test runs normally. Thank you.
Attachment #8702192 -
Flags: review?(lchang)
Comment 3•8 years ago
|
||
Comment on attachment 8702192 [details] [review] [gaia] Fischer-L:bug_1235300-set-ready-state-for-JSMarionette > mozilla-b2g:master Looks good. Thanks.
Attachment #8702192 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Land to Master: https://github.com/Fischer-L/gaia/commit/b1e472387992d4b67981350248c77891d5081c48 Test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=b1e472387992d4b67981350248c77891d5081c48
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 5•8 years ago
|
||
Ever since this landed [1], Gij has looked really flaky on gaia-master [2]. Fischer, can you take a look? 1.) https://treeherder.mozilla.org/#/jobs?repo=gaia-master&revision=c17216015df9 2.) https://treeherder.mozilla.org/#/jobs?repo=gaia-master
Flags: needinfo?(fliu)
Comment 6•8 years ago
|
||
I'm going to back this out for now since I don't want people to think that all the blues in GijTV is normal. reverted in master: https://github.com/mozilla-b2g/gaia/commit/209a027cdb55f6bfa47447d845d509db58c8df4e
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(fliu)
Assignee | ||
Comment 7•8 years ago
|
||
@Luke, The bug 1236723 has fixed the over-run GijTV issue. I have tried 5 times of tests in the PR #33762 and the test results are all passed. This patch is to re-enable GijTV tests. It does: * Make the smart system call document.body.setAttribute('ready-state', 'fullyLoaded') to let JSMarionette know ready to test. * Modify the core.js to use Promise * Modify the tv_apps/smart-system/test/marionette/app_modal_dialog_test.js, tv_apps/smart-system/test/marionette/browser_context_menu_test.js and tv_apps/smart-system/test/marionette/lib/system.js based on other phone Gij test examples Thank you @Evan, Could you please take a look at the following scripts about marionette testing: tv_apps/smart-system/test/marionette/app_modal_dialog_test.js tv_apps/smart-system/test/marionette/browser_context_menu_test.js tv_apps/smart-system/test/marionette/lib/system.js Thank you
Attachment #8702192 -
Attachment is obsolete: true
Attachment #8704511 -
Flags: review?(lchang)
Attachment #8704511 -
Flags: feedback?(evan)
Comment 8•8 years ago
|
||
Comment on attachment 8704511 [details] [review] PR #33762 LGTM, but has some nits.
Attachment #8704511 -
Flags: feedback?(evan) → feedback+
Comment 9•8 years ago
|
||
Comment on attachment 8704511 [details] [review] PR #33762 Looks good! Just don't forget to address Evan's comments. Thanks.
Attachment #8704511 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 10•8 years ago
|
||
@Luke, The smart-dialog has been updated to close dialog on Backspace key not Esc key any more in the commit [1]. So I update browser_context_menu_test.js again to test pressing backspace after menu shown. I also update the tests based on Evan's comments. The tests of this update have been run 5 times as well and all passed. Please have a look, thank you [1] https://github.com/smart-components/smart-dialog/commit/711a71436522d212e7f54213edfa475bf05d0de0
Attachment #8704511 -
Attachment is obsolete: true
Attachment #8707853 -
Flags: review?(lchang)
Assignee | ||
Comment 11•8 years ago
|
||
@Luke, The patch has been updated to split tests to open only the app_modal_dialog_test.js first ,thank you
Comment 12•8 years ago
|
||
Comment on attachment 8707853 [details] [review] PR #31627-2 Looks good. Only one comment left on GitHub. Thanks.
Attachment #8707853 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 13•8 years ago
|
||
Land to master: https://github.com/mozilla-b2g/gaia/commit/193f5bf74105e108ba7648722f01ce8a65f8eaba
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Blocks: gij-tv-system
Updated•6 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•