Manage STK in js/panel/icc

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gasolin@mozilla.com, Assigned: gasolin@mozilla.com)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
to make more modular structure, we'd moving STK handler into js/panel/icc
Created attachment 8702240 [details] [review]
[gaia] gasolin:issue-1235337 > mozilla-b2g:master
(Assignee)

Updated

2 years ago
Assignee: nobody → gasolin
(Assignee)

Comment 2

2 years ago
Comment on attachment 8702240 [details] [review]
[gaia] gasolin:issue-1235337 > mozilla-b2g:master

The patch moved icc.js (STK menu) into js/panel for more organized code structure
Attachment #8702240 - Flags: review?(scwwu)

Comment 3

2 years ago
Comment on attachment 8702240 [details] [review]
[gaia] gasolin:issue-1235337 > mozilla-b2g:master

Code looks fine. Please test on a device if you can, thanks! r+
Attachment #8702240 - Flags: review?(scwwu) → review+
(Assignee)

Comment 4

2 years ago
It's pity that I can't find SIM card on hand that support STK now... 

Call for QA's help to test if the SIM Card Toolkit function is fine with this patch.
Keywords: qawanted
Hi Fred,
I have tested the SIM Card Toolkit function, one problem has been found in latest v2.5&master build, the steps to reproduce are as follow:

Preconditon: There is a valid UNICOM SIM card in the device.
1. Go to STK in settings.
2. Tap one business.
3. Cancel or Subscribe the business.
4. After sending the Operator message, tap Close or OK button in "Operator message" view
>>It will go back to the business list.
5. Tap any business.
>>There is no response even if you relaunch settings.

Device: Flame KK v2.5 512mb(Affected) 
Build ID               20160105125513
Gaia Revision          50c5babe34fb2b055da34fdde6847aabffe73246
Gaia Date              2016-01-05 10:22:12
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d8517b54e27903b9f0a94d76470b4f8126e09eb0
Gecko Version          44.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20160105.120745
Firmware Date          Tue Jan  5 12:07:54 UTC 2016
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK master 512mb(Affected)
Build ID               20160105150220
Gaia Revision          78b2bc4cad3fcf83cbbbe4aeb77079cf956972cf
Gaia Date              2016-01-04 16:24:13
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/29258f59e5456a1a518ccce6b473b50c1173477e
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20160105.200611
Firmware Date          Tue Jan  5 20:06:24 EST 2016
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries kk v2.5(Affected)
Build ID               20160105132122
Gaia Revision          50c5babe34fb2b055da34fdde6847aabffe73246
Gaia Date              2016-01-05 10:22:12
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/d8517b54e27903b9f0a94d76470b4f8126e09eb0
Gecko Version          44.0
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20160105.125332
Firmware Date          Tue Jan  5 12:53:40 UTC 2016
Bootloader             s1
 
Device: Aries KK master(Affected)  
Build ID               20160105233743
Gaia Revision          16ebbfb6ce62c14573982b0aa87537ef8f857047
Gaia Date              2016-01-05 17:54:39
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/aaef0e7e3514acb79418e8fe75f26c6b3d9d18c5
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20160106.001526
Firmware Date          Wed Jan  6 00:15:33 UTC 2016
Bootloader             s1
QA Whiteboard: [MGSEI-Triage+]
Keywords: qawanted
(Assignee)

Comment 6

2 years ago
zouyi thanks for through test!

The above mentioned issue seems worth to file a new bug.
 
And I'd like to know if there's any function broken when you apply this patch?
Flags: needinfo?(yi.zou)
(Assignee)

Comment 7

2 years ago
merged https://github.com/mozilla-b2g/gaia/commit/b4213d991a82640c07a5ad50e453268589d32e6b

Please file another issue if above error still occur
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Hi Fred, 
The issue of above error has been submitted (see bug 1237547), and it still exists on latest build of Aries v2.5&master and Flame v2.5&master 512mb.
Flags: needinfo?(yi.zou)
You need to log in before you can comment on or make changes to this bug.