Closed
Bug 1235367
Opened 8 years ago
Closed 8 years ago
IonMonkey: MIPS64: Use 4-instruction to load 48-bit immedate
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: hev, Assigned: hev)
Details
Attachments
(1 file)
|
1.55 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
The old load instruction sequence: ori $at, $zero, 0x00 (bit47-bit32) dsll $at, $at, 16 ori $at, $at, 0x00 (bit31-bit16) dsll $at, $at, 16 ori $at, $at, 0x00 (bit15-bit0) and new: lui $at, 0x00 (bit47-bit32) ori $at, 0x00 (bit31-bit16) dsll $at, $at, 16 ori $at, $at, 0x00 (bit15-bit0)
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8702270 -
Flags: review?(arai.unmht)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8702270 [details] [diff] [review] 0001-IonMonkey-MIPS64-Use-4-instruction-to-load-48-bit-im.patch Review of attachment 8702270 [details] [diff] [review]: ----------------------------------------------------------------- Nice optimization :)
Attachment #8702270 -
Flags: review?(arai.unmht) → review+
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9418ed133ce0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•