IonMonkey: MIPS64: Use 4-instruction to load 48-bit immedate

RESOLVED FIXED in Firefox 46

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: hev, Assigned: hev)

Tracking

unspecified
mozilla46
Other
Linux
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The old load instruction sequence:
ori   $at, $zero, 0x00 (bit47-bit32)
dsll  $at, $at, 16
ori   $at, $at, 0x00   (bit31-bit16)
dsll  $at, $at, 16
ori   $at, $at, 0x00   (bit15-bit0)

and new:
lui   $at, 0x00        (bit47-bit32)
ori   $at, 0x00        (bit31-bit16)
dsll  $at, $at, 16
ori   $at, $at, 0x00   (bit15-bit0)
(Assignee)

Comment 1

3 years ago
Created attachment 8702270 [details] [diff] [review]
0001-IonMonkey-MIPS64-Use-4-instruction-to-load-48-bit-im.patch
Attachment #8702270 - Flags: review?(arai.unmht)
Comment on attachment 8702270 [details] [diff] [review]
0001-IonMonkey-MIPS64-Use-4-instruction-to-load-48-bit-im.patch

Review of attachment 8702270 [details] [diff] [review]:
-----------------------------------------------------------------

Nice optimization :)
Attachment #8702270 - Flags: review?(arai.unmht) → review+

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9418ed133ce0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.