"Clear Search" string note needs improvement

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: stef, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Added in https://github.com/mozilla/firefox-ios/commit/29fdc5907b358c050c193b381f65f8b3efa13f9a#diff-5cc03b4c973dda33230e94c658a77d9eR61

Without actually reading a patch it is not clear what "Clear Search" string represents and how it should be translated.
Created attachment 8702571 [details]
clear_search.png

Sorry about this - I don't think this was part of the strings landing last Monday.

This string is used for VoiceOver to tell the user about the 'X' button in the search field. Tapping the 'X' will erase the typed input and close searching. See the attached image for the behaviour.

What are your thoughts on a better description?
(Reporter)

Comment 2

3 years ago
(In reply to Stephan Leroux [:sleroux] from comment #1)
> Sorry about this - I don't think this was part of the strings landing last
> Monday.

I'm not sure what you mean by that, it was merged to master on December 16 in https://github.com/mozilla/firefox-ios/pull/1338

> This string is used for VoiceOver to tell the user about the 'X' button in
> the search field. Tapping the 'X' will erase the typed input and close
> searching. See the attached image for the behaviour.
> 
> What are your thoughts on a better description?

Maybe something similar to other notes for VoiceOver strings describing not only the effects (search clearing) but also element (VoiceOver command). Try searching for VoiceOver on https://github.com/splewako/firefox-ios-l10n-en/blame/master/en.xliff
Ah makes sense. How about:

'Accessibility message e.g. spoken by VoiceOver after the user taps the close button in the search field to clear the search and exit search mode'
(Reporter)

Comment 4

3 years ago
(In reply to Stephan Leroux [:sleroux] from comment #3)
> Ah makes sense. How about:
> 
> 'Accessibility message e.g. spoken by VoiceOver after the user taps the
> close button in the search field to clear the search and exit search mode'

Much better.
Created attachment 8702647 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1388
Attachment #8702647 - Flags: review?(splewako)
(Reporter)

Comment 6

3 years ago
Comment on attachment 8702647 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1388

I'm not reviewer but the updated comment sounds clear enough for me.
Attachment #8702647 - Flags: review?(splewako) → feedback+
Attachment #8702647 - Flags: review?(sarentz)
Attachment #8702647 - Flags: review?(sarentz) → review+
master 4f060b3c479d1241fa597ec32b65c075d0c71de3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.