Closed Bug 1235423 Opened 9 years ago Closed 9 years ago

refactor feedback view handling code

Categories

(Input Graveyard :: Code Quality, defect)

Product:
Input Graveyard
Component:
Code Quality
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

Over the years, the needs of Input have changed. One of those groups of needs is the ability to offer different feedback forms depending on the product specified in the url. Over the years, some of the requirements we had have come and gone. The result is that we have some pretty gnarly feedback handling view code that's tightly coupled, hard to reason about, not flexible and generally not fun to work with. This bug covers refactoring that view handling code such that: 1. products can have their own feedback forms and thank you pages and flow control that's easy to read, reason about and test 2. the infrastructure is loosely coupled, so it's easy to add and remove products without having to touch the code in forty different places
Justin is working on a new android form. Any changes here should be run by him so that he can comment ("Yes, this makes my life easier...", "No, please don't do that...", "Have you gone insane?", ...).
Grabbing this to do now.
Assignee: nobody → willkg
WIP PR here: https://github.com/mozilla/fjord/pull/725 That doesn't address fixing the feedback from -> thank you part of the flow. Right now that always leads you to the generic thank you page. It shouldn't. I also haven't run through the smoketests. So there's still some testing to do with this.
We can't push this week, so I'll push this out next week. Justin: You should be all set to proceed with the Android feedback form.
Status: NEW → ASSIGNED
Pushed out just now. I kept an eye on the slightly improved Input health dashboard and everything looks ok. Marking this FIXED.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.