Move "z-index: 2147483647 !important" for :-moz-full-screen from ua.css to gaia code

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
This z-index is no longer necessary for fullscreen as we now render almost all fullscreen elements in the top layer (bug 1126230). The only exceptions are :root and <iframe mozbrowser>.

It seems there have been various hack in gaia code to promote system UI on top of fullscreen element, which we could probably get rid of now, because it no longer makes sense to keep the "important" z-index setting in ua.css.

But getting rid of that would need conjunct ‎work between gecko code and gaia code, which I have no idea how to.

A potential first step is to add a rule in gaia/apps/system/style/zindex.css to keep the current setting of fullscreen element, then remove the line from ua.css. And after that, remaining clean-up work could happen inside gaia code without touching the gecko code.
(Assignee)

Updated

3 years ago
Blocks: 1235471
Created attachment 8702429 [details] [review]
[gaia] upsuper:bug1235470 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8702429 - Flags: review?(etienne)
Comment on attachment 8702429 [details] [review]
[gaia] upsuper:bug1235470 > mozilla-b2g:master

stamp :)
Attachment #8702429 - Flags: review?(etienne) → review+
(Assignee)

Updated

3 years ago
Assignee: nobody → quanxunzhen
(Assignee)

Comment 3

3 years ago
If the gaia code gets landed, I think I can reland my patch in bug 1215365 directly then.
Blocks: 1215365
Summary: Remove "z-index: 2147483647 !important" for :-moz-full-screen from ua.css → Move "z-index: 2147483647 !important" for :-moz-full-screen from ua.css to gaia code
(Assignee)

Comment 4

3 years ago
Could you merge that pull request for me? I don't have write access to b2g repos.
Flags: needinfo?(etienne)
https://github.com/mozilla-b2g/gaia/commit/e6af1a860be409ab80f55207cddd0248565c57a4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(etienne)
Resolution: --- → FIXED
Blocks: 1240434
You need to log in before you can comment on or make changes to this bug.