123550 - Toggling unread column doesn't properly toggle unread counts in name column

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

The fix to bug 123285 has changed the way the unread column is toggled, so
msgMail3PaneWindow.js no longer catches the correct event.

Comment 1

[[e-mail]]

Attachment: Proposed Patch A

Comment 2

[[e-mail]]

Attachment: Proposed patch B

Comment 3

[[e-mail]]

Attachment: Proposed patch C

Comment 4

[[e-mail]]

Attachment: Proposed Patch D

Comment 5

[(not reading, please use [e-mail] instead)]

neil, are patches A-C obsolete?  if so, please mark them and I'll review what's 
not obsolete.

Comment 6

[timeless]

r=timeless for D. seth: these are all valid patches, it's a style thing, and 
since you own mailnews you should take the time to decide what your code really 
means.  i can point to plenty of times where people (esp. me) make a suggestion 
that works but which isn't right/inline with what the module owner intends to 
do in the future.

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 67918 [details] [diff] [review]
Proposed Patch D

sr=sspitzer, assuming that event.newValue is always either "true" or "false"

Comment 8

[Håkan Waara]

This bug is marked as 0.9.9.  Someone needs to mail drivers with a trunk, or
branch approval.  Neil? (see tinderbox for instructions)

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 67918 [details] [diff] [review]
Proposed Patch D

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 10

[Quinn Yost (mythdraug)]

Just curious:  Any chance this will also fix bug 121660?

Comment 11

[[e-mail]]

Fix was checked in by timeless.

Comment 12

[laurel]

OK using mar19 commercial trunk: linuxrh6.2, win98
Toggling the unread column reflects proper change in Unread counts in the Folder
pane Unread column, the Thread pane unread column (threaded mode) and the unread
count appearing in the status bar.