[JSMarionette] Allow passing options to client.helper.waitForElement

RESOLVED FIXED in 2.6 S5 - 1/15

Status

RESOLVED FIXED
3 years ago
7 months ago

People

(Reporter: mikehenrty, Assigned: mikehenrty)

Tracking

unspecified
2.6 S5 - 1/15

Details

(Whiteboard: [MJS][systemsfe])

Attachments

(1 attachment)

Similar to bug 1233880, we should be able to pass in a custom timeout to waitForElement as well as waitForElementToDisappear. Let's do that!
Created attachment 8702519 [details] [review]
[gaia] mikehenrty:bug-1235531-custom-timeout-waitforelement > mozilla-b2g:master
Comment on attachment 8702519 [details] [review]
[gaia] mikehenrty:bug-1235531-custom-timeout-waitforelement > mozilla-b2g:master

Aus or Gareth, can either of you have a look?
Attachment #8702519 - Flags: review?(gaye)
Attachment #8702519 - Flags: review?(aus)
We don't actually need this for bug 1222215 anymore since I have worked around that by just disabling more tests :(, but we still need this in the long run to re-enable tetss.
No longer blocks: 1222215

Comment 4

3 years ago
Comment on attachment 8702519 [details] [review]
[gaia] mikehenrty:bug-1235531-custom-timeout-waitforelement > mozilla-b2g:master

looks fine to me but you'll also want to bump the version of the helper since we 'added' a feature to one of the functions. Looks like we could simply set it to 0.3.3 from 0.3.2.
Attachment #8702519 - Flags: review?(aus) → review+
(In reply to Aus Lacroix [:aus] from comment #4)
> looks fine to me but you'll also want to bump the version of the helper
> since we 'added' a feature to one of the functions. Looks like we could
> simply set it to 0.3.3 from 0.3.2.

Good call!

master: https://github.com/mozilla-b2g/gaia/commit/0a94cf45f864dcfbb2b6694a3f692bded8328d91
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S5 - 1/15

Updated

7 months ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.