1235531 - [JSMarionette] Allow passing options to client.helper.waitForElement

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Similar to bug 1233880, we should be able to pass in a custom timeout to waitForElement as well as waitForElementToDisappear. Let's do that!

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1235531-custom-timeout-waitforelement > mozilla-b2g:master

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8702519 [details] [review]
[gaia] mikehenrty:bug-1235531-custom-timeout-waitforelement > mozilla-b2g:master

Aus or Gareth, can either of you have a look?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

We don't actually need this for bug 1222215 anymore since I have worked around that by just disabling more tests :(, but we still need this in the long run to re-enable tetss.

Comment 4

[Aus Lacroix [:aus]]

Comment on attachment 8702519 [details] [review]
[gaia] mikehenrty:bug-1235531-custom-timeout-waitforelement > mozilla-b2g:master

looks fine to me but you'll also want to bump the version of the helper since we 'added' a feature to one of the functions. Looks like we could simply set it to 0.3.3 from 0.3.2.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Aus Lacroix [:aus] from comment #4)
> looks fine to me but you'll also want to bump the version of the helper
> since we 'added' a feature to one of the functions. Looks like we could
> simply set it to 0.3.3 from 0.3.2.

Good call!

master: https://github.com/mozilla-b2g/gaia/commit/0a94cf45f864dcfbb2b6694a3f692bded8328d91