1235535 - [Testcase] Split the audio channel muted-by-default test from "test_browserElement_inproc/oop_AudioChannel.html."

Status: RESOLVED FIXED

(Firefox OS Graveyard :: AudioChannel, defect)

Description

[Alastor Wu [:alwu]]

Split the muted-by-default test case out from test_browserElement_inproc/oop_AudioChannel.html.

In this bug, I want to solve following problems,

(1) Improve the drawback of the previous implementation 
Modify some codes in order to let the test message more clear.

(2) Reduce time-out probability
The test case becomes more often time-out recently after landing bug1223298.

Comment 1

[Alastor Wu [:alwu]]

Attachment: MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.

Review commit: https://reviewboard.mozilla.org/r/29121/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29121/

Comment 2

[Alastor Wu [:alwu]]

Attachment: MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.

Review commit: https://reviewboard.mozilla.org/r/29123/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29123/

Comment 3

[Alastor Wu [:alwu]]

[Correct the description]
(2) Reduce time-out probability
The test case becomes more often time-out recently after landing "bug1223261".

Comment 4

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a16a8c418596

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8702532 [details]
MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29121/diff/1-2/

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8702533 [details]
MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29123/diff/1-2/

Comment 7

[Alastor Wu [:alwu]]

Hi, Baku,

Could you help me review this patch?
Very appreciate!

---

The purpose of this patch are,

(1) Improve the drawback of the previous implementation 
Modify some codes in order to let the test message more clear.

(2) Reduce time-out probability
The test case becomes more often time-out recently after landing "bug1223261".

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 8702533 [details]
MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.

https://reviewboard.mozilla.org/r/29123/#review25993

Comment 9

[Andrea Marchesini [:baku]]

Comment on attachment 8702532 [details]
MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.

https://reviewboard.mozilla.org/r/29121/#review25995

Comment 10

[Alastor Wu [:alwu]]

Thanks :)

Comment 11

[Carsten Book [:Tomcat]]

Hi, this failed to apply:

applying 9d7ec1f8877c
9d7ec1f8877c transplanted to 8e57ce8b2671
applying 592e70e87fcb
patching file dom/browser-element/mochitest/mochitest.ini
Hunk #3 FAILED at 137
1 out of 4 hunks FAILED -- saving rejects to file dom/browser-element/mochitest/mochitest.ini.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 8702532 [details]
MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29121/diff/1-2/

Comment 13

[Alastor Wu [:alwu]]

Comment on attachment 8702533 [details]
MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29123/diff/1-2/

Comment 14

[Alastor Wu [:alwu]]

Rebase, thanks!

Comment 15

[Carsten Book [:Tomcat]]

Hi, still has problems it seems 

applying 8e0b6d5ad2b5
patching file dom/browser-element/mochitest/mochitest.ini
Hunk #3 FAILED at 137
1 out of 4 hunks FAILED -- saving rejects to file dom/browser-element/mochitest/mochitest.ini.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue

Comment 16

[Alastor Wu [:alwu]]

Comment on attachment 8702532 [details]
MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29121/diff/2-3/

Comment 17

[Alastor Wu [:alwu]]

Comment on attachment 8702533 [details]
MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29123/diff/2-3/

Comment 18

[Alastor Wu [:alwu]]

Hi, Carsten,
Could you help me try it again?
I rebased this patch on the following version,
Very appreciate!

changeset:   278453:29258f59e545
tag:         qparent
parent:      278332:6e01570011a6
parent:      278452:fc4fd9433e21
user:        Carsten "Tomcat" Book <[e-mail]>
date:        Tue Jan 05 11:58:56 2016 +0100
summary:     merge mozilla-inbound to mozilla-central a=merge

Comment 19

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0beb3e22b4b5
https://hg.mozilla.org/integration/mozilla-inbound/rev/76209c880c78

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Something from this push broke weightmapping-12579.html on OSX 10.10: https://treeherder.mozilla.org/logviewer.html#?job_id=19315024&repo=mozilla-inbound

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/9f1486908504

Comment 21

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd8dbe86837f
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec14c601f4c8

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd8dbe86837f
https://hg.mozilla.org/mozilla-central/rev/ec14c601f4c8