1235538 - Intermittent TEST-UNEXPECTED-FAIL | apps/music/test/marionette/Player_test.js | Music player tests Status bar Check the play icon is in the status bar. moztrap:9742

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

When I disable the retry logic in bug 1222215, I see this test failing in a couple different ways, but it's mostly related to checking the statusbar player icon. I think I have a fix for this, bug I'm going to disable this test in the meantime to unblock bug 1222215, and then submit a patch for review.

TEST-UNEXPECTED-FAIL | apps/music/test/marionette/Player_test.js | Music player tests Status bar Check the play icon is in the status bar. moztrap:9742
AssertionError: 'true' == 'false'
    at Context.<anonymous> (apps/music/test/marionette/Player_test.js:189:14)
    at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
-- https://treeherder.mozilla.org/logviewer.html#?job_id=3235208&repo=gaia

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

disabled in master: https://github.com/mozilla-b2g/gaia/commit/d99dadef7ab4dbd32c68969facfef79a252a3b59

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1218013-player-test-waiting > mozilla-b2g:master

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8702541 [details] [review]
[gaia] mikehenrty:bug-1218013-player-test-waiting > mozilla-b2g:master

Evan, it looks like you are familiar with this part of the test, can you take a look?

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8702541 [details] [review]
[gaia] mikehenrty:bug-1218013-player-test-waiting > mozilla-b2g:master

Michael, nice work. LGTM.

Comment 5

[Hubert Figuiere [:hub]]

I would have preferred you ask the review from the modules owners. We own the tests for Music.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/b3f1ab9bec84b23d2724b7ad8036bfaf2c85fb49

Comment 7

[Intermittent Failures Robot]

5 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 5

Platform breakdown:
* mulet-linux64: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1235538&startday=2016-02-01&endday=2016-02-07&tree=all