Closed Bug 1235538 Opened 6 years ago Closed 6 years ago

Intermittent TEST-UNEXPECTED-FAIL | apps/music/test/marionette/Player_test.js | Music player tests Status bar Check the play icon is in the status bar. moztrap:9742

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mikehenrty, Assigned: mikehenrty)

References

Details

(Keywords: intermittent-failure, Whiteboard: [MJS])

Attachments

(1 file)

When I disable the retry logic in bug 1222215, I see this test failing in a couple different ways, but it's mostly related to checking the statusbar player icon. I think I have a fix for this, bug I'm going to disable this test in the meantime to unblock bug 1222215, and then submit a patch for review.

TEST-UNEXPECTED-FAIL | apps/music/test/marionette/Player_test.js | Music player tests Status bar Check the play icon is in the status bar. moztrap:9742
AssertionError: 'true' == 'false'
    at Context.<anonymous> (apps/music/test/marionette/Player_test.js:189:14)
    at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
-- https://treeherder.mozilla.org/logviewer.html#?job_id=3235208&repo=gaia
Comment on attachment 8702541 [details] [review]
[gaia] mikehenrty:bug-1218013-player-test-waiting > mozilla-b2g:master

Evan, it looks like you are familiar with this part of the test, can you take a look?
Attachment #8702541 - Flags: review?(evan)
Comment on attachment 8702541 [details] [review]
[gaia] mikehenrty:bug-1218013-player-test-waiting > mozilla-b2g:master

Michael, nice work. LGTM.
Attachment #8702541 - Flags: review?(evan) → review+
I would have preferred you ask the review from the modules owners. We own the tests for Music.
Attachment #8702541 - Flags: review+
master: https://github.com/mozilla-b2g/gaia/commit/b3f1ab9bec84b23d2724b7ad8036bfaf2c85fb49
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.