1235565 - [experiment] Show the preferences to enable Tracking Protection in non-private windows in more cases

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[:Paolo Amadini]

At some point we'd like to experiment with a change to the preferences dialog that will show user controls to opt in to Tracking Protection for non-private windows in more cases than we currently do.

Currently, the opt-in to Tracking Protection can be done using about:config in all channels. The controls to opt in from the preferences dialog can already be displayed in Nightly after changing a separate about:config preference.

We might still want to show the preferences only in some cases, for example only in pre-beta channels.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Remove the polaris pref and enable the UI to toggle TP in normal mode by default

As discussed, this patch removes the polaris pref that isn't useful any longer and changes the normal mode TP UI to be enabled by default. If we later decide to hold the feature from release we can toggle the pref in a subsequent channel.

Comment 2

[:Paolo Amadini]

Comment on attachment 8705983 [details] [diff] [review]
Remove the polaris pref and enable the UI to toggle TP in normal mode by default

Removing code is always good!

I think we can use this logic for the UI preference, until we decide what to do with channels other than Nightly:

#ifdef NIGHTLY_BUILD
pref("privacy.trackingprotection.ui.enabled", true);
#else
pref("privacy.trackingprotection.ui.enabled", false);
#endif

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Remove the polaris pref and enable the UI to toggle TP in normal mode by default

Updated patch to only enable the UI by default in nightly.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d9a65ae92a91

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d9a65ae92a91

Comment 6

[Paul Silaghi, QA [:pauly]]

browser.polaris.enabled is gone.
privacy.trackingprotection.ui.enabled=TRUE by default.
Verified fixed FF 46.0a1 (2016-01-13) Win 7, Ubuntu 14.04, OS X 10.9.5.