Closed
Bug 1235576
Opened 10 years ago
Closed 10 years ago
Fix the indentation in dom/ipc
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(2 files)
|
675.17 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
167.70 KB,
patch
|
Details | Diff | Splinter Review |
Currently dom/ipc/ header and impl files are a mess from an indentation point of view.
I'm touching these files a lot and all the time I think: we should fix this.
This patch does something. It's not perfect but it's a good starting point.
Attachment #8702595 -
Flags: review?(bugs)
Comment 1•10 years ago
|
||
Ok, after spending half an hour for this I realized I really need -w patch for this.
Comment 2•10 years ago
|
||
"Fix the indentation" does not seem to cover all the changes in your patch.
| Assignee | ||
Comment 3•10 years ago
|
||
Actually, I just added some empty lines, fix the indentation from 4 spaces to 2 spaces, and add a couple of 'const' to simple getter methods.
Comment 4•10 years ago
|
||
Comment on attachment 8702595 [details] [diff] [review]
indent.patch
Waiting for the -w patch
Attachment #8702595 -
Flags: review?(bugs)
| Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8702595 -
Attachment is obsolete: true
Attachment #8703825 -
Flags: review?(bugs)
Updated•10 years ago
|
Attachment #8703825 -
Flags: review?(bugs)
Comment 6•10 years ago
|
||
Comment on attachment 8702595 [details] [diff] [review]
indent.patch
r+ based on the -w patch.
Attachment #8702595 -
Attachment is obsolete: false
Attachment #8702595 -
Flags: review+
Comment 8•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•