Closed Bug 1235576 Opened 4 years ago Closed 4 years ago

Fix the indentation in dom/ipc

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(2 files)

Attached patch indent.patchSplinter Review
Currently dom/ipc/ header and impl files are a mess from an indentation point of view.
I'm touching these files a lot and all the time I think: we should fix this.
This patch does something. It's not perfect but it's a good starting point.
Attachment #8702595 - Flags: review?(bugs)
Ok, after spending half an hour for this I realized I really need -w patch for this.
"Fix the indentation" does not seem to cover all the changes in your patch.
Actually, I just added some empty lines, fix the indentation from 4 spaces to 2 spaces, and add a couple of 'const' to simple getter methods.
Comment on attachment 8702595 [details] [diff] [review]
indent.patch

Waiting for the -w patch
Attachment #8702595 - Flags: review?(bugs)
Attached patch a.patchSplinter Review
Attachment #8702595 - Attachment is obsolete: true
Attachment #8703825 - Flags: review?(bugs)
Attachment #8703825 - Flags: review?(bugs)
Comment on attachment 8702595 [details] [diff] [review]
indent.patch

r+ based on the -w patch.
Attachment #8702595 - Attachment is obsolete: false
Attachment #8702595 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/8af6d41e7d3b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.