1235610 - Add xpctall support for Bitrig and DragonFly

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jan Beich]

Downstream keeps the following patches which are simple enough to take almost as is. DragonFly targets only x86_64 nowadays while Bitrig - x86_64 and arm.

https://github.com/bitrig/bitrig-ports/blob/fd91df9/www/mozilla-firefox/patches/patch-xpcom_reflect_xptcall_md_unix_moz_build
https://github.com/DragonFlyBSD/DeltaPorts/blob/0a739ab/ports/www/firefox/dragonfly/patch-xpcom_reflect_xptcall_md_unix_moz.build

Comment 1

[Jan Beich]

Attachment: MozReview Request: Bug 1235610 - Add xpctall support for Bitrig and DragonFly. r?glandium

Review commit: https://reviewboard.mozilla.org/r/29157/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29157/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8702641 [details]
MozReview Request: Bug 1235610 - Add xpctall support for Bitrig and DragonFly. r?glandium

https://reviewboard.mozilla.org/r/29157/#review27657

::: xpcom/reflect/xptcall/md/unix/moz.build:105
(Diff revision 1)
> -if CONFIG['CPU_ARCH'] == 'arm' and CONFIG['OS_ARCH'] == 'OpenBSD':
> +if CONFIG['CPU_ARCH'] == 'arm' and CONFIG['OS_ARCH'] in ('Bitrig', 'OpenBSD'):

Bitrig doesn't support the other architectures OpenBSD supports?

Comment 3

[Jan Beich]

(In reply to Mike Hommey [:glandium] from comment #2)
> Bitrig doesn't support the other architectures OpenBSD supports?

devel/llvm port suggests aarch64 support in future. For an up-to-date list of supported targets see /sys/arch [1]. Some ports (e.g. binutils, gdb) still carry patches for i386 despite removal [2].

Not sure if any other/previous arm besides armv7 is actually supported.

[1] https://github.com/bitrig/bitrig/tree/master/sys/arch
    http://mirror2.us.bitrig.org/pub/bitrig/snapshots/ (what's regularly built)
[2] https://github.com/bitrig/bitrig/commit/989920deeca8665210fbac7bba09d972e6fed809

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/61385448b7ad

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/61385448b7ad