I'm rearraging the editor embedding code in MfcEmbed so that it follows the same guidelines as the past enhancements to it have been. The functionality has not changed but i've made the following modifications: 1. New Editor window creation code now lives alongside NewBrowser window creation code in MfcEmbed.cpp(not in BrowserFrm.cpp as before) 2. Moved all editor specific code away from BrowserFrm to it's own file - it's now in EditorFrm - this way we keep the browser/editor functionality separate. 3. We no longer have EditorImpl object inheriting from BrowserImpl - this is not correct. This functionality is now folded into EditorFrm which inherits from BrowserFrm. 4. We were crashing whenever one chose "New Editor Window" from an existing Editor frame window. There were two different menu id's for the same menu item being used in two different places. One of them was the same as the PrintOptions menu item resulting in the PrintOptions being chosen when we wanted to create an Editor window 5. General tabbing/spacing cleanup in the old editor embedding code 6. Added copyright headers to the existing/new files 7. Other misc. cleanup Mike/Adam/Saari : Can one of you please r=? Alec : Can you please sr=?
Really adding mjudge to Cc: this time....
Comment on attachment 67919 [details] [diff] [review] Patch to rearrange the editor embedding code... r=adamlock Couple of nits: * "No newline at end of file" in EditorFrm.h * Destructor for CCommandObserver should be protected since it's an object
Hi Adam : I took care of the issues you pointed out...thanks for the quick review...
Addigng Ken Runyon to the CC: list....
Comment on attachment 67919 [details] [diff] [review] Patch to rearrange the editor embedding code... sure.. sr=alecf
Attachment #67919 - Flags: superreview+
Fix checked in...Thank you Adam/Alec for your reviews.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Verified changes in MfcEmbed source, using Mozilla trunk 0.9.8 Gecko 20010209: BrowserFrm.cpp / .h BrowserImpl.cpp / .h CCommandObserver.cpp / .h (new files) EditorFrm.cpp / .h (new files) MfcEmbed.cpp / .h MfcEmbed.rc makefile.win MfcEmbed.dsp
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.