1235738 - Move MOZ_DEBUG_DEFINES to build frontend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Move MOZ_DEBUG_DEFINES to build frontend

MOZ_DEBUG_DEFINES are essentially defines used everywhere. So treat them as
feeding the initial value for DEFINES in each moz.build sandbox. This allows
the kind overrides that was done in the past by resetting MOZ_DEBUG_DEFINES
in Makefiles.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Simplify MOZ_DEBUG_DEFINES

Now that it's not directly used in command lines, it can just become a list
of symbols that ought to be defined. This simplifies all the uses of it.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8702821 [details] [diff] [review]
Move MOZ_DEBUG_DEFINES to build frontend

Review of attachment 8702821 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/context.py
@@ +281,5 @@
>          self._sandbox().pop_subcontext(self)
>  
>  
> +class InitializedDefines(ContextDerivedValue, OrderedDict):
> +    def __init__(self, context, value={}):

Using {} as the default value is dangerous. Use None and then "values = values or {}"

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8702822 [details] [diff] [review]
Simplify MOZ_DEBUG_DEFINES

Review of attachment 8702822 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a68ebf32f83
https://hg.mozilla.org/integration/mozilla-inbound/rev/51b8dcf42ee0

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a6ef68947e7

Comment 7

[Mike Hommey [:glandium]]

(In reply to Pulsebot from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/5a6ef68947e7

As mentioned in the commit message there, it turns out we weren't passing debug flags in HOST_C{,XX}FLAGS before. I'll file a followup for that.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3a68ebf32f83
https://hg.mozilla.org/mozilla-central/rev/51b8dcf42ee0
https://hg.mozilla.org/mozilla-central/rev/5a6ef68947e7