Closed Bug 1235738 Opened 4 years ago Closed 4 years ago

Move MOZ_DEBUG_DEFINES to build frontend

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

No description provided.
MOZ_DEBUG_DEFINES are essentially defines used everywhere. So treat them as
feeding the initial value for DEFINES in each moz.build sandbox. This allows
the kind overrides that was done in the past by resetting MOZ_DEBUG_DEFINES
in Makefiles.
Attachment #8702821 - Flags: review?(gps)
Now that it's not directly used in command lines, it can just become a list
of symbols that ought to be defined. This simplifies all the uses of it.
Attachment #8702822 - Flags: review?(gps)
Comment on attachment 8702821 [details] [diff] [review]
Move MOZ_DEBUG_DEFINES to build frontend

Review of attachment 8702821 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/context.py
@@ +281,5 @@
>          self._sandbox().pop_subcontext(self)
>  
>  
> +class InitializedDefines(ContextDerivedValue, OrderedDict):
> +    def __init__(self, context, value={}):

Using {} as the default value is dangerous. Use None and then "values = values or {}"
Attachment #8702821 - Flags: review?(gps) → review+
Comment on attachment 8702822 [details] [diff] [review]
Simplify MOZ_DEBUG_DEFINES

Review of attachment 8702822 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8702822 - Flags: review?(gps) → review+
(In reply to Pulsebot from comment #6)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/5a6ef68947e7

As mentioned in the commit message there, it turns out we weren't passing debug flags in HOST_C{,XX}FLAGS before. I'll file a followup for that.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.