1235740 - New startup terminal-spew: "Failed to load Oculus VR library!"

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

With my debug mozilla-inbound build (not sure about opt builds), I'm noticing the following output among the first few lines of terminal output, every time I start Firefox:
> Failed to load Oculus VR library!

(I'm on Ubuntu 15.10, and I've never setup any VR-specific stuff. Presumably there's some library we're looking for & failing to find on my system.)

I'm guessing this only just started appearing because we just recently preffed VR on by default, and we only look for these libs if VR is preffed on, it sounds like from bug 1113242.

I could see this message being helpful in the past when diagnosing issues with power-users who've opted in to trying VR and are likely to have the occulus toolkit installed.  But now that VR is preffed on by default, this is much more likely to just be background-noise / terminal-spam.

So: can we get rid of this error-message, or make it opt-in/better-targeted in some way?

Comment 1

[Daniel Holbert [:dholbert]]

Looks like this message comes from one of these printf_stderr spots:
 https://hg.mozilla.org/mozilla-central/annotate/9ddf0da90fb3/gfx/vr/gfxVROculus.cpp#l154
 https://hg.mozilla.org/mozilla-central/annotate/9ddf0da90fb3/gfx/vr/gfxVROculus050.cpp#l158

ni=vlad for how best to resolve this, since he's on 'hg blame' for this error-message & hence is in a position to evaluate its value.

Comment 2

[Daniel Holbert [:dholbert]]

(Actually, with e10s enabled [the default], this message gets spammed *twice* in my first few lines of terminal-output -- first from the chrome process, and again a bit later from the content process when it starts up [I assume].)

Comment 3

[:kip (Kearwood Gilbert)]

I can take this and remove the excess spew.  I believe this debug output is not needed any more.  WebVR has just been enabled in the latest nightly.

Comment 4

[:kip (Kearwood Gilbert)]

Attachment: MozReview Request: Bug 1235740 - Remove warning for missing Oculus VR Library from terminal output, as it is spammy and not necessary

Review commit: https://reviewboard.mozilla.org/r/29251/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29251/

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8703011 [details]
MozReview Request: Bug 1235740 - Remove warning for missing Oculus VR Library from terminal output, as it is spammy and not necessary

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29251/diff/1-2/

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 8703011 [details]
MozReview Request: Bug 1235740 - Remove warning for missing Oculus VR Library from terminal output, as it is spammy and not necessary

https://reviewboard.mozilla.org/r/29251/#review26047

Looks good!

One nit: the commit message is a bit generic ("Remove debug output spam from terminal output").

Maybe it should say something like "Remove warning for missing Oculus VR Library", or something else that mentions Oculus and/or VR.

r=me regardless

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8703011 [details]
MozReview Request: Bug 1235740 - Remove warning for missing Oculus VR Library from terminal output, as it is spammy and not necessary

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29251/diff/1-2/

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/100f409cb8fa

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/100f409cb8fa