1235748 - Stop doing post-processing on include flags for CompileDB and codecomplete

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Stop post-processing include flags for CompileDB and codecomplete

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8702840 [details] [diff] [review]
Stop post-processing include flags for CompileDB and codecomplete

Review of attachment 8702840 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/compilation/codecomplete.py
@@ +15,5 @@
>  )
>  
>  from mozbuild.base import MachCommandBase
>  from mozbuild.shellutil import quote as shell_quote
> +from mozbuild.shellutil import split as shell_split

You can combine this into a single statement:

from mozbuild.shellutil import (
    quote as shell_quote,
    split as shell_split,
)

::: python/mozbuild/mozbuild/compilation/database.py
@@ +15,5 @@
>      UnifiedSources,
>      GeneratedSources,
>  )
>  from mozbuild.shellutil import quote as shell_quote
> +from mozbuild.shellutil import split as shell_split

Ditto.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/300fa08da26b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/300fa08da26b