1235762 - Set network timeout for TV

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Sync, defect)

Description

[Michiel de Jong [:michielbdejong]]

Follow-up to bug 1224203 which set a 180 seconds network timeout, but only for the phone (not for the TV).

Setting this timeout was unnecessary so far because the Kinto.js version currently used on the TV has a 240 seconds timeout, but newer Kinto.js only have a 5 second timeout, which is too short for FxSync, so we will have to set a higher value explicitly from now on.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1235762-network-timeout-v2.5 > mozilla-b2g:v2.5

Comment 2

[Michiel de Jong [:michielbdejong]]

Waiting for TreeHerder.

Comment 3

[Michiel de Jong [:michielbdejong]]

Lots of unrelated TreeHerder errors [1] - is that normal for the v2.5 branch?

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=260e07f847fa52d26da99624212a65d75c9bdb29

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Hey Michiel,

The failed test are not related to TV codes.
The file that JsHint mentioned seems be fixed in the latest master.
Could you help to rebase your branch to the latest master?

Thanks.

Comment 5

[Michiel de Jong [:michielbdejong]]

Hi Sean, it's impossible to rebase this PR on master because it changes files (path: apps/sync) that only exist in the v2.5 branch. The corresponding files in master are under path shared/js/sync, and already contain these changes (see https://github.com/mozilla-b2g/gaia/pull/33523/files)

Comment 6

[Sean Lee [:seanlee][:weilonge]]

Hi Michiel,

Could you remove your commit and push an empty PR to verify if all these errors are caused by yours?
I suppose these errors are not caused by yours.

And I found the jshint error is caused by bug 1223668 comment 14 .
I think there are plenty of test issues have be resolved but no dependency on this patch.

Hi Josh,

If Michiel confirms that the plenty errors are not caused by his patch.
How do you think we still land this patch to v2.5 branch?

Comment 7

[Sean Lee [:seanlee][:weilonge]]

the bug owner bug 1223668 knows the issue now. clear Josh's ni to wait for Michiel's result.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:v2.5-noop > mozilla-b2g:v2.5

Comment 9

[Michiel de Jong [:michielbdejong]]

See https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=d2cd29ef82e31316b229190abd53d77919886291

Comment 10

[Sean Lee [:seanlee][:weilonge]]

This PR for bug 1222016 has the same error result
https://github.com/mozilla-b2g/gaia/pull/33707

Comment 11

[Michiel de Jong [:michielbdejong]]

Superseded by bug 1236863, which brings the entire sync app in line with master.